Retrieve node name from metadata service

[cemakd]

What type of PR is this?
/kind bug

What this PR does / why we need it:
Use the MetadataServer to retrieve Node name similar to #2277

Which issue(s) this PR fixes:
Fixes #2276

Without this fix we see:

Warning  FailedAttachVolume  4m57s (x39 over 80m)  attachdetach-controller  AttachVolume.Attach failed for
 volume "pvc-507bb954-97fa-40aa-98c1-c78e849cac0d" : rpc error: code = InvalidArgument desc = Failed to get
 instance: googleapi: Error 400: Invalid value for field 'instance': 'test-gcp10-wf7zf-worker-c-6kgqn.c.ocpstrat-
1278.internal'. Must be a match of regex '[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?|[1-9][0-9]{0,19}'

For GCE operations like attach, it is still using the short name as identifier for the operation, which is what we got from the nodeID. We need to switch this back to use the short name instead of the long name case.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix Attach Failure for VM with Long Name Format

[sunnylovestiramisu]

Not clear of what error will this cause, because we can use the long name as the fully qualified name.

/hold

[sunnylovestiramisu]

A sample error is:

Warning  FailedAttachVolume  58m (x6 over 80m)     attachdetach-controller  AttachVolume.Attach failed for volume
 "pvc-507bb954-97fa-40aa-98c1-c78e849cac0d" : rpc error: code = InvalidArgument desc = ControllerPublish not
 permitted on node "projects/ocpstrat-1278/zones/us-central1-c/instances/test-gcp10-wf7zf-worker-c-
6kgqn.c.ocpstrat-1278.internal" due to backoff condition

Warning  FailedAttachVolume  4m57s (x39 over 80m)  attachdetach-controller  AttachVolume.Attach failed for
 volume "pvc-507bb954-97fa-40aa-98c1-c78e849cac0d" : rpc error: code = InvalidArgument desc = Failed to get
 instance: googleapi: Error 400: Invalid value for field 'instance': 'test-gcp10-wf7zf-worker-c-6kgqn.c.ocpstrat-
1278.internal'. Must be a match of regex '[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?|[1-9][0-9]{0,19}'

We should fix the regex instead?

[suzezhang]

We don't want to change the regex for GCE API here. The real issue is that projects/ocpstrat-1278/zones/us-central1-c/instances/test-gcp10-wf7zf-worker-c-6kgqn.c.ocpstrat-1278.internal does not exist in GCE. There is a mismatch between the GCE Instance name and the cluster name:

• test-gcp10-wf7zf-worker-c-6kgqnis GCE Instance name.
• test-gcp10-wf7zf-worker-c-6kgqn.c.ocpstrat-1278.internal is the cluster Node name.

[sunnylovestiramisu]

/unhold

[hajiler]

/lgtm

[sunnylovestiramisu]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cemakd, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sunnylovestiramisu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment