STOR-2396: Rebase to upstream v1.20.0 for OCP 4.20#79
Merged
openshift-merge-bot[bot] merged 159 commits intoopenshift:masterfrom Jul 30, 2025
Merged
STOR-2396: Rebase to upstream v1.20.0 for OCP 4.20#79openshift-merge-bot[bot] merged 159 commits intoopenshift:masterfrom
openshift-merge-bot[bot] merged 159 commits intoopenshift:masterfrom
Conversation
Bumps golang from 1.23.0 to 1.24.0. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the onsi group with 1 update in the / directory: [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo). Updates `github.com/onsi/ginkgo/v2` from 2.20.1 to 2.22.2 - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.20.1...v2.22.2) Updates `github.com/onsi/gomega` from 1.34.1 to 1.36.2 - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.34.1...v1.36.2) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: onsi - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor dependency-group: onsi ... Signed-off-by: dependabot[bot] <support@github.com>
…ot/go_modules/onsi-6da7530402 Bump the onsi group across 1 directory with 2 updates
Bumps the golang-x group with 7 updates in the / directory: | Package | From | To | | --- | --- | --- | | [golang.org/x/oauth2](https://github.com/golang/oauth2) | `0.21.0` | `0.27.0` | | [golang.org/x/sys](https://github.com/golang/sys) | `0.28.0` | `0.30.0` | | [golang.org/x/time](https://github.com/golang/time) | `0.5.0` | `0.10.0` | | [golang.org/x/crypto](https://github.com/golang/crypto) | `0.31.0` | `0.35.0` | | [golang.org/x/mod](https://github.com/golang/mod) | `0.20.0` | `0.23.0` | | [golang.org/x/net](https://github.com/golang/net) | `0.33.0` | `0.35.0` | | [golang.org/x/tools](https://github.com/golang/tools) | `0.24.0` | `0.30.0` | Updates `golang.org/x/oauth2` from 0.21.0 to 0.27.0 - [Commits](golang/oauth2@v0.21.0...v0.27.0) Updates `golang.org/x/sys` from 0.28.0 to 0.30.0 - [Commits](golang/sys@v0.28.0...v0.30.0) Updates `golang.org/x/time` from 0.5.0 to 0.10.0 - [Commits](golang/time@v0.5.0...v0.10.0) Updates `golang.org/x/crypto` from 0.31.0 to 0.35.0 - [Commits](golang/crypto@v0.31.0...v0.35.0) Updates `golang.org/x/mod` from 0.20.0 to 0.23.0 - [Commits](golang/mod@v0.20.0...v0.23.0) Updates `golang.org/x/net` from 0.33.0 to 0.35.0 - [Commits](golang/net@v0.33.0...v0.35.0) Updates `golang.org/x/sync` from 0.10.0 to 0.11.0 - [Commits](golang/sync@v0.10.0...v0.11.0) Updates `golang.org/x/term` from 0.27.0 to 0.29.0 - [Commits](golang/term@v0.27.0...v0.29.0) Updates `golang.org/x/text` from 0.21.0 to 0.22.0 - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.21.0...v0.22.0) Updates `golang.org/x/tools` from 0.24.0 to 0.30.0 - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.24.0...v0.30.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang-x - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang-x - dependency-name: golang.org/x/time dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang-x - dependency-name: golang.org/x/crypto dependency-type: indirect update-type: version-update:semver-minor dependency-group: golang-x - dependency-name: golang.org/x/mod dependency-type: indirect update-type: version-update:semver-minor dependency-group: golang-x - dependency-name: golang.org/x/net dependency-type: indirect update-type: version-update:semver-minor dependency-group: golang-x - dependency-name: golang.org/x/sync dependency-type: indirect update-type: version-update:semver-minor dependency-group: golang-x - dependency-name: golang.org/x/term dependency-type: indirect update-type: version-update:semver-minor dependency-group: golang-x - dependency-name: golang.org/x/text dependency-type: indirect update-type: version-update:semver-minor dependency-group: golang-x - dependency-name: golang.org/x/tools dependency-type: indirect update-type: version-update:semver-minor dependency-group: golang-x ... Signed-off-by: dependabot[bot] <support@github.com>
check for VG cleanup
Adding additional checks for data cache watcher and reduceVolumeGroup
Fix build issues for Windows image.
…ot/docker/golang-1.24.0 Bump golang from 1.23.0 to 1.24.0
…ot/go_modules/golang-x-9a5330b321 Bump the golang-x group across 1 directory with 10 updates
github.com/emicklei/go-restful needed to be updated, but to v3 which also required updating k8s openapi. Change-Id: I9dc0fad79785450904db38702a4cae077e6dfbca
Bumps golang from 1.24.0 to 1.24.1. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Pass performance parameters when creating regional disks.
Update change log and docs for release v1.17.1 to master
…vailableLSSDsBug Fix logic bug while checking available LSSDs for RAIDing for Data Cache
Add exponential backoff retries for getting Node from API server logic
…m-location-tpc-fix Add handling for TPC to GetRegionFromZones
chao007
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@chao007 I would merge kubernetes-sigs@a28ea05 into the general openshift carry |
|
Hi @dfajmon, chao is PTO from July 8th~16th ^^, if it is not urgent we could wait her back to squash the commits. If it needs to merge ASAP, I could help with the squash. |
|
It can wait, no worries. |
and remove .github go mod vendor && go mod tidy UPSTREAM: <carry>: Updating ose-gcp-pd-csi-driver-container image to be consistent with ART for 4.20 Reconciling with https://github.com/openshift/ocp-build-data/tree/dfb5c7d531490cfdc61a3b88bc533702b9624997/images/ose-gcp-pd-csi-driver.yml
|
/test e2e-gcp |
|
Notable changes test with pre merge build summarize
$ oc apply -f - << EOF
allowVolumeExpansion: true
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
name: hyperdisk-rox
parameters:
replication-type: none
type: hyperdisk-balanced
access-mode: READ_ONLY_MANY
provisioner: pd.csi.storage.gke.io
reclaimPolicy: Delete
volumeBindingMode: WaitForFirstConsumer
EOF
$ oc apply -f podWithFs.yaml,pvc.yaml
pod/mypod created
persistentvolumeclaim/mypvc created
$ oc get pvc,pv
NAME STATUS VOLUME CAPACITY ACCESS MODES STORAGECLASS VOLUMEATTRIBUTESCLASS AGE
persistentvolumeclaim/mypvc Bound pvc-86a4f327-f97f-4e8b-8f09-640750e933bc 10Gi RWO hyperdisk-rox <unset> 9s
NAME CAPACITY ACCESS MODES RECLAIM POLICY STATUS CLAIM STORAGECLASS VOLUMEATTRIBUTESCLASS REASON AGE
persistentvolume/pvc-86a4f327-f97f-4e8b-8f09-640750e933bc 10Gi RWO Delete Bound default/mypvc hyperdisk-rox
$ gcloud compute disks describe pvc-86a4f327-f97f-4e8b-8f09-640750e933bc \
--zone=us-central1-f \
--project=openshift-qe
accessMode: READ_WRITE_SINGLE
creationTimestamp: '2025-07-23T01:02:32.238-07:00'
description: '{"kubernetes.io/created-for/pv/name":"pvc-86a4f327-f97f-4e8b-8f09-640750e933bc","kubernetes.io/created-for/pvc/name":"mypvc","kubernetes.io/created-for/pvc/namespace":"default","storage.gke.io/created-by":"pd.csi.storage.gke.io"}'
enableConfidentialCompute: false
id: '3149914114406296055'
kind: compute#disk
labelFingerprint: jKytrsr7b_w=
labels:
kubernetes-io-cluster-pewang-0723g-hrs2q: owned
name: pvc-86a4f327-f97f-4e8b-8f09-640750e933bc
physicalBlockSizeBytes: '4096'
provisionedIops: '3060'
provisionedThroughput: '155'
satisfiesPzi: false
selfLink: https://www.googleapis.com/compute/v1/projects/openshift-qe/zones/us-central1-f/disks/pvc-86a4f327-f97f-4e8b-8f09-640750e933bc
sizeGb: '10'
status: READY
type: https://www.googleapis.com/compute/v1/projects/openshift-qe/zones/us-central1-f/diskTypes/hyperdisk-balanced
zone: https://www.googleapis.com/compute/v1/projects/openshift-qe/zones/us-central1-f
|
|
All regression CI looks good from QE side, just waiting for the final review and RWX snaps supports does not support in this rebase version yet still waiting for conclusion whether we need a newer version to rebase. |
|
@chao007 The carry patch commit message should be -> |
…ter HyperDisk-HA and let such validations occur at the PD control plane layer
|
@chao007: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I tested with the update(cherry-picked the kubernetes-sigs#2116), the hyperdisk raw block RWX snapshot create and restore works well(Test record). |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chao007, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
[ART PR BUILD NOTIFIER] Distgit: ose-gcp-pd-csi-driver |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link:
https://issues.redhat.com/browse/STOR-2396
Diff to upstream v1.20.0:
kubernetes-sigs/gcp-compute-persistent-disk-csi-driver@v1.20.0...chao007:gcp-pd-csi-driver:rebase-1.20.0
Notable changes between v1.17.4 (OCP 4.19) and v1.20.0 (OCP 4.20):
Full changelogs:
https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/releases/tag/v1.20.0
@openshift/storage
@openshift/storage-qe