Introduce Disk Topology Feature#1983
Conversation
|
Hi @julianKatz. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
a23f433 to
d73f071
Compare
d73f071 to
c0f81d1
Compare
c0f81d1 to
b2bf395
Compare
d8497dd to
baf7abf
Compare
baf7abf to
df19d2a
Compare
|
/ok-to-test |
we will rely solely on the binary flag to decide when to apply the labels
75188fd to
51b7f9e
Compare
|
@julianKatz: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julianKatz, mattcary, tonyzhc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR introduces a new, flag-gated feature: Disk Topology.
GKE will be adding new labels to its nodes that indicate the GCP disk products that each node is compatible with.
With the addition of these new disk type labels to nodes, we can include disk type labels in workload scheduling. To affect that, those labels will be included in a PersistentVolume's
NodeAffinityclause. This PR includes a disk support label consistent with thetypespecified in the StorageClass in each of the Topology segments included inCreateVolumeResponse. External Provisioner will then read these and add them as NodeAffinity requirements on the PV.The feature is gated on the newly introduced
--disk-topology=[true|false]flag, which is disabled by default.Special notes for your reviewer: None.
Does this PR introduce a user-facing change?:
Yes, users can set the flag to
trueand enable the new functionality.