Skip to content

Relax volumeContentSource restriction for ROX multi-zone dynamic volume creation#1975

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
pwschuurman:pdcsi-rox-multi-zone-create
Apr 2, 2025
Merged

Relax volumeContentSource restriction for ROX multi-zone dynamic volume creation#1975
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
pwschuurman:pdcsi-rox-multi-zone-create

Conversation

@pwschuurman
Copy link
Copy Markdown
Contributor

This enables empty ROX multi-zone PVCs to be created, to allow for static hydration of disks

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: Currently ROX multi-zone volumes can only be created from a volume source (eg: snapshot/disk image). This limits the flexibility of a user that wants to create a ROX multi-zone volume which is empty, and then write the same data individually to each created disk. This allows all disks to share the same name (as they are part of a "multi-zone" volume), but have data populated without needing to pre-create a snapshot/disk image (as copying data directly to each individual disk in parallel can be faster than creating and restoring from a snapshot).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Relax multi-zone volume ROX restriction when creating a volume without a volumeContentSource.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 5, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwschuurman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 5, 2025
@pwschuurman
Copy link
Copy Markdown
Contributor Author

/retest

3 similar comments
@pwschuurman
Copy link
Copy Markdown
Contributor Author

/retest

@pwschuurman
Copy link
Copy Markdown
Contributor Author

/retest

@pwschuurman
Copy link
Copy Markdown
Contributor Author

/retest

@pwschuurman pwschuurman force-pushed the pdcsi-rox-multi-zone-create branch 2 times, most recently from 7f86194 to 21f8bc4 Compare March 26, 2025 05:10
@pwschuurman pwschuurman force-pushed the pdcsi-rox-multi-zone-create branch from 21f8bc4 to 268e1ac Compare April 1, 2025 00:25
@pwschuurman
Copy link
Copy Markdown
Contributor Author

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

1 similar comment
@pwschuurman
Copy link
Copy Markdown
Contributor Author

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

…me creation. This enables empty ROX multi-zone PVCs to be created, to allow for static hydration of disks
@pwschuurman pwschuurman force-pushed the pdcsi-rox-multi-zone-create branch from 268e1ac to 297c9ee Compare April 1, 2025 23:51
@pwschuurman
Copy link
Copy Markdown
Contributor Author

/assign @dannawang0221

Comment thread pkg/gce-pd-csi-driver/controller.go
@dannawang0221
Copy link
Copy Markdown
Contributor

lgtm

@dannawang0221
Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2ec1e10 into kubernetes-sigs:master Apr 2, 2025
9 checks passed
@pwschuurman
Copy link
Copy Markdown
Contributor Author

/cherrypick release-1.17

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@pwschuurman: new pull request created: #2036

Details

In response to this:

/cherrypick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants