Skip to content

OCPBUGS-77428: Pass node name to csi-driver container#172

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
noamasu:OCPBUGS-77428/add-node-name-to-csi-driver
Feb 27, 2026
Merged

OCPBUGS-77428: Pass node name to csi-driver container#172
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
noamasu:OCPBUGS-77428/add-node-name-to-csi-driver

Conversation

@noamasu
Copy link
Copy Markdown
Contributor

@noamasu noamasu commented Feb 26, 2026

The upstream deploy manifest passes --node-name to the csi-driver container but the operator's node.yaml was missing it. Without it, the driver uses the short GCP instance name instead of the full node name (FQDN), causing Node object lookups to fail

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 26, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@noamasu: This pull request references Jira Issue OCPBUGS-77428, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The upstream deploy manifest passes --node-name to the csi-driver container but the operator's node.yaml was missing it. Without it, the driver uses the short GCP instance name instead of the Kubernetes node name (FQDN), causing Node object lookups to fail on OpenShift.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from gnufied and rhrmo February 26, 2026 21:16
@noamasu noamasu force-pushed the OCPBUGS-77428/add-node-name-to-csi-driver branch from cf6628a to a8c2648 Compare February 26, 2026 21:28
@noamasu noamasu changed the title OCPBUGS-77428: Pass node name to csi-driver container via Downward API OCPBUGS-77428: Pass node name to csi-driver container Feb 26, 2026
The upstream deploy manifest passes --node-name to the csi-driver container
but the operator's node.yaml was missing it. Without it, the driver uses the
short GCP instance name instead of the node name (FQDN), causing
Node object lookups to fail.

Signed-off-by: Noam Assouline <nassouli@redhat.com>
@noamasu noamasu force-pushed the OCPBUGS-77428/add-node-name-to-csi-driver branch from a8c2648 to 9cd8bdb Compare February 26, 2026 21:38
@mpatlasov
Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 26, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@mpatlasov: This pull request references Jira Issue OCPBUGS-77428, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 26, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 27, 2026

@noamasu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mpatlasov
Copy link
Copy Markdown
Contributor

/lgtm
/approve
/verified by @noamasu

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 27, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@mpatlasov: This PR has been marked as verified by @noamasu.

Details

In response to this:

/lgtm
/approve
/verified by @noamasu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov, noamasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit aac0254 into openshift:main Feb 27, 2026
11 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@noamasu: Jira Issue Verification Checks: Jira Issue OCPBUGS-77428
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-77428 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

The upstream deploy manifest passes --node-name to the csi-driver container but the operator's node.yaml was missing it. Without it, the driver uses the short GCP instance name instead of the full node name (FQDN), causing Node object lookups to fail

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mpatlasov
Copy link
Copy Markdown
Contributor

/cherry-pick release-4.21

@openshift-cherrypick-robot
Copy link
Copy Markdown

@mpatlasov: new pull request created: #173

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

Fix included in accepted release 4.22.0-0.nightly-2026-03-02-153725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants