Skip to content

CFE-543 : Apply user defined tags to all Azure resources created by OpenShift#1191

Merged
openshift-merge-robot merged 29 commits intoopenshift:masterfrom
bharath-b-rh:azure-tags
Jan 25, 2023
Merged

CFE-543 : Apply user defined tags to all Azure resources created by OpenShift#1191
openshift-merge-robot merged 29 commits intoopenshift:masterfrom
bharath-b-rh:azure-tags

Conversation

@bharath-b-rh
Copy link
Contributor

@bharath-b-rh bharath-b-rh commented Jul 18, 2022 •
edited
Loading

PR is a design proposal to support user defined tags for the Azure resources created by Openshift. Proposal is to allow user to request for tags to be added for all the Azure resources.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

dhellmann
dhellmann reviewed Jul 18, 2022
View reviewed changes
TrilokGeer
TrilokGeer reviewed Jul 19, 2022
View reviewed changes
jewzaam
jewzaam reviewed Jul 22, 2022
View reviewed changes
@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented Aug 18, 2022

@jewzaam Apologies for responding late and thank you for the comments.

@bharath-b-rh bharath-b-rh marked this pull request as ready for review August 24, 2022 11:14
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2022
@openshift-ci openshift-ci bot requested review from jwmatthews and sjenning August 24, 2022 11:16
This was referenced Sep 1, 2022
Merged
Merged
JoelSpeed
JoelSpeed reviewed Sep 5, 2022
View reviewed changes
bparees
bparees reviewed Sep 6, 2022
View reviewed changes
Miciah
Miciah reviewed Jan 12, 2023
View reviewed changes
@bharath-b-rh bharath-b-rh mentioned this pull request Jan 18, 2023
Merged
Miciah
Miciah reviewed Jan 19, 2023
View reviewed changes
Miciah
Miciah reviewed Jan 19, 2023
View reviewed changes
Miciah
Miciah reviewed Jan 19, 2023
View reviewed changes
@Miciah
Copy link
Contributor

Miciah commented Jan 19, 2023

I have a few lingering comments (#1191 (comment), #1191 (comment), #1191 (comment)), but nothing blocking. Overall LGTM.

@Miciah
Copy link
Contributor

Miciah commented Jan 23, 2023

The latest changes LGTM. Thanks for your patience!

@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented Jan 23, 2023

/cc @jerpeter1

@openshift-ci openshift-ci bot requested a review from jerpeter1 January 23, 2023 05:03
jerpeter1
jerpeter1 reviewed Jan 25, 2023
View reviewed changes
jerpeter1
jerpeter1 reviewed Jan 25, 2023
View reviewed changes
@jerpeter1
Copy link
Member

jerpeter1 commented Jan 25, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerpeter1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2023
@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented Jan 25, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2023
@bharath-b-rh
Copy link
Contributor Author

bharath-b-rh commented Jan 25, 2023

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2023

@bharath-b-rh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0d30f22 into openshift:master Jan 25, 2023
@bharath-b-rh bharath-b-rh deleted the azure-tags branch January 25, 2023 18:43
@bharath-b-rh bharath-b-rh mentioned this pull request Feb 6, 2023
Merged
@chiragkyal chiragkyal mentioned this pull request Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhellmann dhellmann dhellmann left review comments

@bparees bparees bparees left review comments

@JoelSpeed JoelSpeed JoelSpeed left review comments

@jerpeter1 jerpeter1 jerpeter1 left review comments

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

@sudhaponnaganti sudhaponnaganti Awaiting requested review from sudhaponnaganti

@jwmatthews jwmatthews Awaiting requested review from jwmatthews

@sjenning sjenning Awaiting requested review from sjenning

@dmage dmage Awaiting requested review from dmage

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@flavianmissi flavianmissi Awaiting requested review from flavianmissi

@TrilokGeer TrilokGeer Awaiting requested review from TrilokGeer

+3 more reviewers

@abutcher abutcher abutcher left review comments

@jewzaam jewzaam jewzaam left review comments

@Miciah Miciah Miciah left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@frobware frobware

@Miciah Miciah

@jerpeter1 jerpeter1

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.