Skip to content

[CFE-678] Add UserTags while creating Azure Storage Account#829

Merged
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
chiragkyal:cfe-678
Feb 15, 2023
Merged

[CFE-678] Add UserTags while creating Azure Storage Account#829
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
chiragkyal:cfe-678

Conversation

@chiragkyal
Copy link
Member

@chiragkyal chiragkyal commented Jan 10, 2023 •
edited
Loading

Related to : openshift/enhancements#1191
API Changes : openshift/api#1280

Add UserTags while creating Azure Storage Account.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2023
@chiragkyal chiragkyal changed the title [CFE-678] Add UserTags while creating Azure Storage Account WIP: [CFE-678] Add UserTags while creating Azure Storage Account Jan 10, 2023
bharath-b-rh
bharath-b-rh reviewed Jan 17, 2023
View reviewed changes
bharath-b-rh
bharath-b-rh reviewed Jan 17, 2023
View reviewed changes
bharath-b-rh
bharath-b-rh reviewed Jan 17, 2023
View reviewed changes
bharath-b-rh
bharath-b-rh reviewed Jan 17, 2023
View reviewed changes
bharath-b-rh
bharath-b-rh reviewed Jan 17, 2023
View reviewed changes
bharath-b-rh
bharath-b-rh reviewed Jan 17, 2023
View reviewed changes
bharath-b-rh
bharath-b-rh reviewed Jan 17, 2023
View reviewed changes
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2023
@chiragkyal chiragkyal changed the title WIP: [CFE-678] Add UserTags while creating Azure Storage Account [CFE-678] Add UserTags while creating Azure Storage Account Feb 9, 2023
@chiragkyal chiragkyal marked this pull request as ready for review February 9, 2023 08:22
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2023
@openshift-ci openshift-ci bot requested review from dmage and flavianmissi February 9, 2023 08:23
@chiragkyal
Copy link
Member Author

chiragkyal commented Feb 10, 2023

/retest-required

@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 10, 2023
@chiragkyal
Copy link
Member Author

chiragkyal commented Feb 10, 2023

/retest-required

@flavianmissi
Copy link
Member

flavianmissi commented Feb 10, 2023

/retest

flavianmissi
flavianmissi reviewed Feb 13, 2023
View reviewed changes
flavianmissi
flavianmissi reviewed Feb 13, 2023
View reviewed changes
flavianmissi
flavianmissi reviewed Feb 13, 2023
View reviewed changes
@bharath-b-rh
Copy link
Contributor

bharath-b-rh commented Feb 14, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2023
@flavianmissi
Copy link
Member

flavianmissi commented Feb 14, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharath-b-rh, chiragkyal, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2023
@chiragkyal
Copy link
Member Author

chiragkyal commented Feb 14, 2023

/retest-required

@bharath-b-rh
Copy link
Contributor

bharath-b-rh commented Feb 14, 2023

/test e2e-azure-ovn

@bharath-b-rh
Copy link
Contributor

bharath-b-rh commented Feb 14, 2023

/test e2e-azure-operator

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2023

@chiragkyal: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Senthamilarasu-STA
Copy link

Senthamilarasu-STA commented Feb 15, 2023

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Feb 15, 2023
@jinyunma
Copy link

jinyunma commented Feb 15, 2023

pre-merge testing is passed, storage account for image registry has expected user defined tags, details can be found in https://issues.redhat.com/browse/CORS-2507
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 15, 2023
@xenolinux
Copy link

xenolinux commented Feb 15, 2023

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Feb 15, 2023
@openshift-merge-robot openshift-merge-robot merged commit 5c81c66 into openshift:master Feb 15, 2023
@chiragkyal chiragkyal deleted the cfe-678 branch February 15, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flavianmissi flavianmissi flavianmissi left review comments

@dmage dmage Awaiting requested review from dmage

+1 more reviewer

@bharath-b-rh bharath-b-rh bharath-b-rh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@bharath-b-rh bharath-b-rh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@chiragkyal @flavianmissi @bharath-b-rh @Senthamilarasu-STA @jinyunma @xenolinux @openshift-merge-robot