Skip to content

CFE-601 : Update openshift/api package version#279

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
bharath-b-rh:cfe-601
Feb 13, 2023
Merged

CFE-601 : Update openshift/api package version#279
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
bharath-b-rh:cfe-601

Conversation

@bharath-b-rh
Copy link
Contributor

openshift/enhancements#1191 proposes support for Azure tags support in OCP and requires changes in openshift/api Infrastructure CRD and is used by openshift/installer for updating the user defined tags, which is made available for installer by cluster-config-operator, which is included in the container image from the openshift/api package and requires the package to be updated to have the latest CRD.

@bharath-b-rh
Copy link
Contributor Author

/cc @deads2k

@openshift-ci openshift-ci bot requested a review from deads2k February 8, 2023 11:41
@bharath-b-rh
Copy link
Contributor Author

/retest

@deads2k
Copy link
Contributor

deads2k commented Feb 9, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 9, 2023
@deads2k
Copy link
Contributor

deads2k commented Feb 9, 2023

/hold

covered by #278 which I've just labelled. That commit is 068b2ae5534f53aa42ec8fff386b0fcf39badb15 which is after 11903e0431cdc3cc5688f33bb720210618cfcea7

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2023
@bharath-b-rh
Copy link
Contributor Author

/retest

1 similar comment
@bharath-b-rh
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2023

@bharath-b-rh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor

deads2k commented Feb 13, 2023

/lgtm
/hold cancel

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharath-b-rh, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2c06ed4 into openshift:master Feb 13, 2023
@bharath-b-rh bharath-b-rh deleted the cfe-601 branch February 13, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants