Skip to content

Conversation

@mpatlasov
Copy link

Diff to upstream v6.2.1:
kubernetes-csi/external-snapshotter@v6.2.1...mpatlasov:rebase-6.2.1

Major changes between 6.1.0 (OCP 4.12) and 6.2.1:

Add --retry-crd-interval-max flag to the snapshot-controller in order to allow customization of CRD detection on startup. (kubernetes-csi#777, @mattcary)
Change webhook example to be compatible with TLS-type secrets. (kubernetes-csi#793, @haslersn)
Fixes an issue introduced by PR 793 by respecting the format of TLS-type secrets in the script. (kubernetes-csi#796, @haslersn)
Update go to v1.19 and kubernetes dependencies to 1.26.0. (kubernetes-csi#797, @sunnylovestiramisu)

Full changelogs:

https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v6.2.1

@openshift/storage

humblec and others added 30 commits November 3, 2022 19:20
update module dependencies to latest version
Change-Id: I870a3d294b4d30abea3f6ecad951d68cfd5c9ceb
Parameterize startup CRD wait retries
add dependabot configuration to github actions for auto update PRs
remove `replace` directive from the go.mod file
Kubernetes has a builtin Secret type `kubernetes.io/tls` which uses the keys `tls.crt` and `tls.key`.
…update-master

Update dependency go modules for k8s v1.26.0-rc.0
Make webhook example compatible with TLS secrets
test: fix trivy and codespell github action failure
After bb95725 the script was broken. This commit fixes this by
respecting the format of TLS-type secrets in the script, too.
…update-master

Update dependency go modules in client for k8s v1.26.0-rc.0
fix certificate generation in webhook example
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 1, 2023

@mpatlasov: This pull request references STOR-1020 which is a valid jira issue.

Details

In response to this:

Diff to upstream v6.2.1:
kubernetes-csi/external-snapshotter@v6.2.1...mpatlasov:rebase-6.2.1

Major changes between 6.1.0 (OCP 4.12) and 6.2.1:

Add --retry-crd-interval-max flag to the snapshot-controller in order to allow customization of CRD detection on startup. (kubernetes-csi#777, @mattcary)
Change webhook example to be compatible with TLS-type secrets. (kubernetes-csi#793, @haslersn)
Fixes an issue introduced by PR 793 by respecting the format of TLS-type secrets in the script. (kubernetes-csi#796, @haslersn)
Update go to v1.19 and kubernetes dependencies to 1.26.0. (kubernetes-csi#797, @sunnylovestiramisu)

Full changelogs:

https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v6.2.1

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 1, 2023
@mpatlasov
Copy link
Author

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Feb 1, 2023
@openshift-ci openshift-ci bot requested review from bertinatto and dobsonj February 1, 2023 02:35
@jsafrane
Copy link

jsafrane commented Feb 1, 2023

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Feb 1, 2023

@mpatlasov: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link

jsafrane commented Feb 1, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2023
@duanwei33
Copy link

Checked the CI results look good for sidecar rebase.

@duanwei33
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 2, 2023
@openshift-merge-robot openshift-merge-robot merged commit e711430 into openshift:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.