Update dependency go modules in client for k8s v1.26.0-rc.0#794
Conversation
|
/assign xing-yang |
|
The script is only running go mod commands, not sure why is it triggering the codespell failure. And the it failed at the vendor code. |
37abe22 to
9ff8e59
Compare
|
We don't seem to run the trivy scanner and codespell checks in other repos: kubernetes-csi/external-provisioner#823 Maybe we should remove them until we can figure out how to make them optional. |
|
The presubmit config does not include the codespell: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-csi/external-snapshotter/external-snapshotter-config.yaml I am not sure where is that added. |
|
It looks like it is supposed to skip vendor: https://github.com/kubernetes-csi/external-snapshotter/pull/658/files#diff-ce84a1b2c9eb4ab3ea22f610cad7111cb9a2f66365c3b24679901376a2a73ab2R15 |
|
The spelling errors are complaining about "./client/vendor/...". There isn't a vendor folder under client. Maybe we need to add "./client/vendor/" to the skip list of that script. cc @andyzhangx |
@sunnylovestiramisu should be fixed by #795, could you rebase this PR on master branch? |
9ff8e59 to
8aeed25
Compare
|
/release-note-none |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sunnylovestiramisu, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ran kubernetes-csi/csi-release-tools go-get-kubernetes.sh -p 1.26.0-rc.0