Skip to content

Update dependency go modules in client for k8s v1.26.0-rc.0#794

Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
sunnylovestiramisu:module-update-master
Dec 6, 2022
Merged

Update dependency go modules in client for k8s v1.26.0-rc.0#794
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
sunnylovestiramisu:module-update-master

Conversation

@sunnylovestiramisu
Copy link
Contributor

Ran kubernetes-csi/csi-release-tools go-get-kubernetes.sh -p 1.26.0-rc.0

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2022
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 5, 2022
@sunnylovestiramisu
Copy link
Contributor Author

/assign xing-yang

@sunnylovestiramisu
Copy link
Contributor Author

The script is only running go mod commands, not sure why is it triggering the codespell failure. And the it failed at the vendor code.

@sunnylovestiramisu sunnylovestiramisu force-pushed the module-update-master branch 2 times, most recently from 37abe22 to 9ff8e59 Compare December 5, 2022 22:52
@msau42
Copy link
Collaborator

msau42 commented Dec 5, 2022

We don't seem to run the trivy scanner and codespell checks in other repos: kubernetes-csi/external-provisioner#823

Maybe we should remove them until we can figure out how to make them optional.

@sunnylovestiramisu
Copy link
Contributor Author

The presubmit config does not include the codespell: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-csi/external-snapshotter/external-snapshotter-config.yaml

I am not sure where is that added.

@xing-yang
Copy link
Collaborator

They are added by these PRs:

#708
#658

@msau42
Copy link
Collaborator

msau42 commented Dec 5, 2022

@xing-yang
Copy link
Collaborator

xing-yang commented Dec 6, 2022

The spelling errors are complaining about "./client/vendor/...". There isn't a vendor folder under client. Maybe we need to add "./client/vendor/" to the skip list of that script.

cc @andyzhangx

@andyzhangx
Copy link
Member

The spelling errors are complaining about "./client/vendor/...". There isn't a vendor folder under client. Maybe we need to add "./client/vendor/" to the skip list of that script.

cc @andyzhangx

@sunnylovestiramisu should be fixed by #795, could you rebase this PR on master branch?

@xing-yang
Copy link
Collaborator

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 6, 2022
@xing-yang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sunnylovestiramisu, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit 40e2a53 into kubernetes-csi:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants