Make webhook example compatible with TLS secrets

[haslersn]

Kubernetes has a builtin Secret type kubernetes.io/tls which uses the keys tls.crt and tls.key.

With this change, when you download the example webhook.yaml, it's immediately compatible with secrets created e.g. by cert-manager. The downloaded file can be integrated into kustomize projects without further modification or patches.

/kind documentation

Change webhook example to be compatible with TLS-type secrets.

[k8s-ci-robot]

Welcome @haslersn!

It looks like this is your first PR to kubernetes-csi/external-snapshotter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-snapshotter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @haslersn. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xing-yang]

/assign @deepakkinni

[xing-yang]

/ok-to-test

[deepakkinni]

/approve

[Kartik494]

/release-note-none

[xing-yang]

@haslersn Please add a release note.

[xing-yang]

/assign

[haslersn]

Please add a release note.

Should be done now.

[xing-yang]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepakkinni, haslersn, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deepakkinni]

I was trying out deploying the webhook as per the docs and i see a CLBO

root@localhost [ ~/csi-snapshot-guest-installation ]# kubectl logs snapshot-validation-deployment-58b598bcc7-m62fk -n kube-system
F1206 07:49:47.336713       1 webhook.go:230] failed to initialize new cert watcher: open /etc/snapshot-validation-webhook/certs/tls.crt: no such file or directory
goroutine 1 [running]:
k8s.io/klog/v2.stacks(0x1)
	/workspace/vendor/k8s.io/klog/v2/klog.go:860 +0x8a
k8s.io/klog/v2.(*loggingT).output(0x1fec080, 0x3, 0x0, 0xc000424850, 0x1, {0x1910556?, 0x1?}, 0x1feca40?, 0x0)
	/workspace/vendor/k8s.io/klog/v2/klog.go:825 +0x686
k8s.io/klog/v2.(*loggingT).printfDepth(0x1fec080, 0x0?, 0x0, {0x0, 0x0}, 0xc0000b1d98?, {0x1492f28, 0x29}, {0xc000418db0, 0x1, ...})
	/workspace/vendor/k8s.io/klog/v2/klog.go:630 +0x1f2
k8s.io/klog/v2.(*loggingT).printf(...)
	/workspace/vendor/k8s.io/klog/v2/klog.go:612
k8s.io/klog/v2.Fatalf(...)
	/workspace/vendor/k8s.io/klog/v2/klog.go:1516
github.com/kubernetes-csi/external-snapshotter/v6/pkg/validation-webhook.main(0x1fd8d80?, {0xc000421120?, 0x2?, 0x2?})
	/workspace/pkg/validation-webhook/webhook.go:230 +0x154
github.com/spf13/cobra.(*Command).execute(0x1fd8d80, {0xc00003a190, 0x2, 0x2})
	/workspace/vendor/github.com/spf13/cobra/command.go:860 +0x663
github.com/spf13/cobra.(*Command).ExecuteC(0x1fd8d80)
	/workspace/vendor/github.com/spf13/cobra/command.go:974 +0x3b4
github.com/spf13/cobra.(*Command).Execute(...)
	/workspace/vendor/github.com/spf13/cobra/command.go:902
main.main()
	/workspace/cmd/snapshot-validation-webhook/main.go:32 +0x5a

I suppose there are changes needed in https://github.com/kubernetes-csi/external-snapshotter/blob/master/deploy/kubernetes/webhook-example/create-cert.sh as well

[haslersn]

That sounds right, the script should also follow the format of TLS-type secrets.

[haslersn]

@deepakkinni does #796 fix your problem?