Skip to content

Conversation

@dobsonj
Copy link
Member

@dobsonj dobsonj commented Aug 18, 2021

Rebase external-provisioner v3.0.0
kubernetes-csi/external-provisioner@release-3.0...dobsonj:rebase-v3.0.0

Manually resolved conflicts in:

  • OWNERS_ALIASES
  • OWNERS

/cc @openshift/storage

bai3shuo4 and others added 30 commits May 1, 2021 11:36
Don't register process_start_time_seconds metric in migration metrics
manager to prevent double registration, resulting in this error:

gathered metric family process_start_time_seconds has help "[ALPHA] Start time of the process since unix epoch in seconds." but should have "Start time of the process since unix epoch in seconds."
kubernetes-csi/csi-release-tools@6616a6b52 Merge kubernetes-csi/csi-release-tools#146 from pohly/kubernetes-1.21
kubernetes-csi/csi-release-tools@510fb0f9c prow.sh: support Kubernetes 1.21
kubernetes-csi/csi-release-tools@c63c61b3b prow.sh: add CSI_PROW_DEPLOYMENT_SUFFIX
kubernetes-csi/csi-release-tools@51ac11c3a Merge kubernetes-csi/csi-release-tools#144 from pohly/pull-jobs
kubernetes-csi/csi-release-tools@dd54c9269 pull-test.sh: test importing csi-release-tools into other repo
kubernetes-csi/csi-release-tools@7d2643a55 Merge kubernetes-csi/csi-release-tools#143 from pohly/path-setup
kubernetes-csi/csi-release-tools@6880b0c80 prow.sh: avoid creating paths unless really running tests
kubernetes-csi/csi-release-tools@bc0504ad7 Merge kubernetes-csi/csi-release-tools#140 from jsafrane/remove-unused-k8s-libs
kubernetes-csi/csi-release-tools@5b1de1adb go-get-kubernetes.sh: remove unused k8s libs
kubernetes-csi/csi-release-tools@49b426937 Merge kubernetes-csi/csi-release-tools#120 from pohly/add-kubernetes-release
kubernetes-csi/csi-release-tools@f7e7ee495 docs: steps for adding testing against new Kubernetes release

git-subtree-dir: release-tools
git-subtree-split: 6616a6b5294b6df39cfce37f4fce7cdce0a77583
…pology-worker

node topology worker should run
The RunWorker used to be more complex, but after some recent changes
it only triggers one goroutine and thus may as well run that code
directly.
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
…ency

Remove dependency to k8s.io/kubernetes
kubernetes-csi/csi-release-tools@f3255906a Merge kubernetes-csi/csi-release-tools#149 from pohly/cluster-logs
kubernetes-csi/csi-release-tools@4b03b3084 Merge kubernetes-csi/csi-release-tools#155 from pohly/owners
kubernetes-csi/csi-release-tools@a6453c86d owners: introduce aliases
kubernetes-csi/csi-release-tools@ad83def42 Merge kubernetes-csi/csi-release-tools#153 from pohly/fix-image-builds
kubernetes-csi/csi-release-tools@556178017 build.make: fix image publishng
kubernetes-csi/csi-release-tools@29bd39b38 Merge kubernetes-csi/csi-release-tools#152 from pohly/bump-csi-test
kubernetes-csi/csi-release-tools@bc427931a prow.sh: use csi-test v4.2.0
kubernetes-csi/csi-release-tools@b546baaf7 Merge kubernetes-csi/csi-release-tools#150 from mauriciopoppe/windows-multiarch-args
kubernetes-csi/csi-release-tools@bfbb6f357 add parameter base_image and addon_image to BUILD_PARAMETERS
kubernetes-csi/csi-release-tools@2d61d3bc3 Merge kubernetes-csi/csi-release-tools#151 from humblec/cm
kubernetes-csi/csi-release-tools@48e71f062 Replace `which` command ( non standard)  with `command -v` builtin
kubernetes-csi/csi-release-tools@feb20e269 prow.sh: collect cluster logs
kubernetes-csi/csi-release-tools@7b96bea3d Merge kubernetes-csi/csi-release-tools#148 from dobsonj/add-checkpathcmd-to-prow
kubernetes-csi/csi-release-tools@2d2e03b7f prow.sh: enable -csi.checkpathcmd option in csi-sanity
kubernetes-csi/csi-release-tools@09d415121 Merge kubernetes-csi/csi-release-tools#147 from pohly/mock-testing
kubernetes-csi/csi-release-tools@74cfbc977 prow.sh: support mock tests
kubernetes-csi/csi-release-tools@4a3f11036 prow.sh: remove obsolete test suppression

git-subtree-dir: release-tools
git-subtree-split: f3255906abf2e4134cb3db4ff79ddfb5ce1e91aa
Fix env name from POD_NAMESPACE to NAMESPACE for capacity-ownerref-level option
Add SupportsBlock method to provisionWrapper for being able to use block device
This is necessary to ensure that the controller sees all of the
objects when it starts.

The previous approach with Create() was used to ensure that namespace
and UID are set. We now have to take care of that manually.
…st-flake

capacity test: create CSIStorageObject before instantiating client-set
Add command line arguments to configure leader election options
Use sig-storage-lib-external-provisioner v7.0.1
@openshift-ci openshift-ci bot requested a review from a team August 18, 2021 16:16
@openshift-ci
Copy link

openshift-ci bot commented Aug 18, 2021

@dobsonj: This pull request references Bugzilla bug 1993934, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

Details

In response to this:

Bug 1993934: Update CSI sidecars

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Aug 18, 2021
@jsafrane
Copy link

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2021
@dobsonj
Copy link
Member Author

dobsonj commented Aug 23, 2021

/verify-owners

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2021
@dobsonj
Copy link
Member Author

dobsonj commented Aug 23, 2021

/verify-owners

@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Aug 23, 2021
@jsafrane
Copy link

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Aug 23, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2021

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift org. You can then trigger verification by writing /verify-owners in a comment.

  • kubernetes-csi-reviewers
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • kubernetes-csi-approvers
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2021

@dobsonj: All pull requests linked via external trackers have merged:

Bugzilla bug 1993934 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1993934: Update CSI sidecars

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build csi-provisioner-container-v4.9.0-202311250023.p0.g7736e72.assembly.stream for distgit csi-provisioner.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.