Skip to content

Conversation

@pohly
Copy link
Contributor

@pohly pohly commented May 21, 2021

Squashed 'release-tools/' changes from 6616a6b52..f3255906a

f3255906a Merge pull request #149 from pohly/cluster-logs
4b03b3084 Merge pull request #155 from pohly/owners
a6453c86d owners: introduce aliases
ad83def42 Merge pull request #153 from pohly/fix-image-builds
556178017 build.make: fix image publishng
29bd39b38 Merge pull request #152 from pohly/bump-csi-test
bc427931a prow.sh: use csi-test v4.2.0
b546baaf7 Merge pull request #150 from mauriciopoppe/windows-multiarch-args
bfbb6f357 add parameter base_image and addon_image to BUILD_PARAMETERS
2d61d3bc3 Merge pull request #151 from humblec/cm
48e71f062 Replace which command ( non standard) with command -v builtin
feb20e269 prow.sh: collect cluster logs
7b96bea3d Merge pull request #148 from dobsonj/add-checkpathcmd-to-prow
2d2e03b7f prow.sh: enable -csi.checkpathcmd option in csi-sanity
09d415121 Merge pull request #147 from pohly/mock-testing
74cfbc977 prow.sh: support mock tests
4a3f11036 prow.sh: remove obsolete test suppression

git-subtree-dir: release-tools
git-subtree-split: f3255906abf2e4134cb3db4ff79ddfb5ce1e91aa

NONE

pohly added 2 commits May 21, 2021 09:28
kubernetes-csi/csi-release-tools@f3255906a Merge kubernetes-csi/csi-release-tools#149 from pohly/cluster-logs
kubernetes-csi/csi-release-tools@4b03b3084 Merge kubernetes-csi/csi-release-tools#155 from pohly/owners
kubernetes-csi/csi-release-tools@a6453c86d owners: introduce aliases
kubernetes-csi/csi-release-tools@ad83def42 Merge kubernetes-csi/csi-release-tools#153 from pohly/fix-image-builds
kubernetes-csi/csi-release-tools@556178017 build.make: fix image publishng
kubernetes-csi/csi-release-tools@29bd39b38 Merge kubernetes-csi/csi-release-tools#152 from pohly/bump-csi-test
kubernetes-csi/csi-release-tools@bc427931a prow.sh: use csi-test v4.2.0
kubernetes-csi/csi-release-tools@b546baaf7 Merge kubernetes-csi/csi-release-tools#150 from mauriciopoppe/windows-multiarch-args
kubernetes-csi/csi-release-tools@bfbb6f357 add parameter base_image and addon_image to BUILD_PARAMETERS
kubernetes-csi/csi-release-tools@2d61d3bc3 Merge kubernetes-csi/csi-release-tools#151 from humblec/cm
kubernetes-csi/csi-release-tools@48e71f062 Replace `which` command ( non standard)  with `command -v` builtin
kubernetes-csi/csi-release-tools@feb20e269 prow.sh: collect cluster logs
kubernetes-csi/csi-release-tools@7b96bea3d Merge kubernetes-csi/csi-release-tools#148 from dobsonj/add-checkpathcmd-to-prow
kubernetes-csi/csi-release-tools@2d2e03b7f prow.sh: enable -csi.checkpathcmd option in csi-sanity
kubernetes-csi/csi-release-tools@09d415121 Merge kubernetes-csi/csi-release-tools#147 from pohly/mock-testing
kubernetes-csi/csi-release-tools@74cfbc977 prow.sh: support mock tests
kubernetes-csi/csi-release-tools@4a3f11036 prow.sh: remove obsolete test suppression

git-subtree-dir: release-tools
git-subtree-split: f3255906abf2e4134cb3db4ff79ddfb5ce1e91aa
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 21, 2021
@k8s-ci-robot k8s-ci-robot requested review from msau42 and saad-ali May 21, 2021 07:29
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 21, 2021
@pohly pohly force-pushed the prow-update-master branch from 5829edd to 4d2615a Compare May 21, 2021 07:42
@pohly pohly changed the title WIP: master: update release-tools + OWNERS master: update release-tools + OWNERS May 21, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2021
@pohly
Copy link
Contributor Author

pohly commented May 21, 2021

/retest

2 similar comments
@pohly
Copy link
Contributor Author

pohly commented May 21, 2021

/retest

@pohly
Copy link
Contributor Author

pohly commented May 22, 2021

/retest

@pohly pohly force-pushed the prow-update-master branch from 4d2615a to 95bde59 Compare May 25, 2021 06:34
@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2021
@pohly
Copy link
Contributor Author

pohly commented May 25, 2021

pull-kubernetes-csi-external-provisioner-distributed-on-kubernetes-1-20 is a new job that is expected to fail until PR #635 is merged.

@k8s-ci-robot k8s-ci-robot merged commit 5f57746 into kubernetes-csi:master May 25, 2021
@pohly
Copy link
Contributor Author

pohly commented May 25, 2021

The new job didn't fail (which is good for this PR) and I now understand why. I need to test with 1.21 for it to fail.

@pohly pohly deleted the prow-update-master branch July 6, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants