capacity test: create CSIStorageObject before instantiating client-set#640
Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom Jun 8, 2021
Merged
Conversation
This is necessary to ensure that the controller sees all of the objects when it starts. The previous approach with Create() was used to ensure that namespace and UID are set. We now have to take care of that manually.
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
cncf-cla: yes
Merged
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind flake
What this PR does / why we need it:
This is necessary to ensure that the controller sees all of the
objects when it starts.
The previous approach with Create() was used to ensure that namespace
and UID are set. We now have to take care of that manually.
Which issue(s) this PR fixes:
Fixes #638
Does this PR introduce a user-facing change?: