Bug 1876791: Rebase to v2.0.0 #31
Conversation
Developers should not be forced to build for all platforms by default. We also don't want to copy-and-paste the go invocation for each new platform. To address both, the target platform(s) are now configurable via BUILD_PLATFORMS and additional platforms are only enabled in the Prow CI. For now this serves as a test that the source actually compiles for multiple platforms. Building images for different target platforms is a different problem.
build for multiple platforms only in CI, add s390x
Signed-off-by: Grant Griffiths <grant@portworx.com>
…pdate Update snapshotter to version 2.0.1
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Correct package import and var declaration
This PR removes the `--enable-leader-election` flag and add `leader-election` flag as other sidecar containers.
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
md linter fixes
To clarify what the version means.
Make leader-election flag consistent with other sidecar
Add links to version in README
…ion-capability Start clone protection only when capability matches
update release tools instructions
Signed-off-by: Grant Griffiths <grant@portworx.com>
…ter_rbac_version_set Fix csi-snapshotter RBAC yaml version
Update patch release notes generation command
Going forward we are using the GA version of the CSINode object in the sidecars. However, Kubernetes v1.16 only contains the v1beta1 version of that object, hence we need to skip the prow job in this version.
Use v1.CSINode in the external-provisioner
Addresses #84226 This change prevents calling DeleteVolume on the CSI plugin for volumes that are still attached to a kubernetes node.
Add VolumeAttachment Lister to CSI Provisioner
The approach taken here extends the existing support for cross-compiling binaries on the build host and specifying the Go compiler: Go is installed if needed (as in Prow testing), binaries are build on the host, then one image is created for each platform, and finally those are combined into a single multi-architecture image.
cloud build: initial set of shared files
Commit summary: bd41690 cloud build: initial set of shared files 6f2322e Update patch release notes generation command d8c76fe Support local snapshot RBAC for pull jobs ea1f94a update release tools instructions 7edc146 Update snapshotter to version 2.0.1 3863a0f build for multiple platforms only in CI, add s390x
master: update release-tools, enable cloud build
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jsafrane: This pull request references Bugzilla bug 1876791, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-medium
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
The last failure was caused by old aws-ebs image used in tests (still uses |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@jsafrane: All pull requests linked via external trackers have merged:
Bugzilla bug 1876791 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
17 participants
Rebase to v2.0.0 for OCP 4.6.
Diff to upstream v2.0.0:
kubernetes-csi/external-provisioner@v2.0.0...jsafrane:rebase-v2.0.0
@openshift/storage