-
Notifications
You must be signed in to change notification settings - Fork 373
Start clone protection only when capability matches #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start clone protection only when capability matches #434
Conversation
|
Hi @Danil-Grigorev. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9bfc937 to
4058667
Compare
|
/assign @jsafrane |
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Danil-Grigorev, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you for the fix! Can we also cherry pick this? |
…update-master Update dependency go modules for k8s v1.27.0
What type of PR is this?
/kind bug
What this PR does / why we need it:
Adds a capability check, to prevent cloning protection from starting, when
CLONE_VOLUMEis not set on the driver.Which issue(s) this PR fixes:
Fixes #431
Special notes for your reviewer:
Does this PR introduce a user-facing change?: