Skip to content

Bug 1876791: Update provisioner container to v2.0.0 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 8, 2020
Merged

Bug 1876791: Update provisioner container to v2.0.0 #27

openshift-merge-robot merged 1 commit into from
Sep 8, 2020

Conversation

@jsafrane
Copy link

@jsafrane jsafrane commented Sep 8, 2020 •
edited
Loading

  • --provisioner has been deprecated and removed upstream.
  • add --default-fstype=ext4 to explicitly default to ext4 (newly introduced in v2.0.0)
  • remove useless topology feature

@openshift/storage

@jsafrane
Remove --provisioner cmdline argument
3c60322 
- --provisioner has been deprecated upstream.
- remove topology, it's not used by oVirt.
- add --default-fstype to set the default fsType of PVs.
@jsafrane
Copy link
Author

jsafrane commented Sep 8, 2020

/test e2e-ovirt

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2020
@jsafrane jsafrane changed the title Remove --provisioner cmdline argument Bug 1876791: Remove --provisioner cmdline argument Sep 8, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 8, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 8, 2020

@jsafrane: This pull request references Bugzilla bug 1876791, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1876791: Remove --provisioner cmdline argument

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 8, 2020
bertinatto
bertinatto reviewed Sep 8, 2020
View reviewed changes
assets/controller.yaml Outdated
args:
- --provisioner=csi.ovirt.org
- --csi-address=$(ADDRESS)
- --feature-gates=Topology=true
Copy link
Member

@bertinatto bertinatto Sep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that topology is true, but the CSI driver doesn't support it. Can we remove it as part of this PR?

Copy link
Author

@jsafrane jsafrane Sep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@jsafrane jsafrane force-pushed the remove-provisioner-cmdline branch 2 times, most recently from df08caf to 3c60322 Compare September 8, 2020 13:50
@jsafrane jsafrane changed the title Bug 1876791: Remove --provisioner cmdline argument Bug 1876791: Update provisioner container to v2.0.0 Sep 8, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 8, 2020

@jsafrane: This pull request references Bugzilla bug 1876791, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1876791: Update provisioner container to v2.0.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bertinatto
bertinatto reviewed Sep 8, 2020
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [bertinatto,jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 33c3d44 into openshift:master Sep 8, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 8, 2020

@jsafrane: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1876791 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1876791: Update provisioner container to v2.0.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 9, 2020
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bennyz bennyz Awaiting requested review from bennyz

1 more reviewer

@bertinatto bertinatto bertinatto left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@bertinatto bertinatto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jsafrane @openshift-ci-robot @bertinatto @openshift-merge-robot