Skip to content

CONSOLE-4095: upgrade Cypress to v13.10.0 #13887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
May 31, 2024
Merged

CONSOLE-4095: upgrade Cypress to v13.10.0 #13887

openshift-merge-bot merged 2 commits into from
May 31, 2024

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented May 22, 2024 •
edited
Loading

In order to resolve Error: This socket has been ended by the other party errors in CI documented in cypress-io/cypress#27552.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 22, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 22, 2024 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4095 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2024
@openshift-ci openshift-ci bot requested review from jcaianirh and spadgett May 22, 2024 14:17
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 22, 2024 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4095 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

In order to resolve Error: This socket has been ended by the other party errors in CI documented in cypress-io/cypress#27552.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Member Author

rhamilto commented May 22, 2024

/retest

@openshift-ci openshift-ci bot added the kind/cypress Related to Cypress e2e integration testing label May 23, 2024
@rhamilto
Copy link
Member Author

rhamilto commented May 23, 2024

/retest

4 similar comments
@rhamilto
Copy link
Member Author

rhamilto commented May 23, 2024

/retest

@rhamilto
Copy link
Member Author

rhamilto commented May 23, 2024

/retest

@rhamilto
Copy link
Member Author

rhamilto commented May 23, 2024

/retest

@rhamilto
Copy link
Member Author

rhamilto commented May 24, 2024

/retest

@rhamilto
Copy link
Member Author

rhamilto commented May 28, 2024

@jerolimov, it looks like this upgrade is resulting in the failure of add-flow-ci.feature. Can someone from the dev console team take a look?

@rhamilto
Copy link
Member Author

rhamilto commented May 28, 2024

@jerolimov, I should note there is a bug preventing Cypress tests from running locally. Fix.

@rhamilto rhamilto mentioned this pull request May 30, 2024
Closed
@alebedev87 alebedev87 mentioned this pull request May 30, 2024
Merged
@rhamilto
Copy link
Member Author

rhamilto commented May 30, 2024

/retest

@rhamilto rhamilto changed the title [WIP] CONSOLE-4095: upgrade Cypress to v13.10.0 CONSOLE-4095: upgrade Cypress to v13.10.0 May 30, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2024
@rhamilto
Copy link
Member Author

rhamilto commented May 30, 2024

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 30, 2024
TheRealJon
TheRealJon approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2024
jhadvig
jhadvig approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rhamilto 🙌
@alebedev87 FYI
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rhamilto, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhamilto
Copy link
Member Author

rhamilto commented May 30, 2024

Tech debt, so assigning approvals:
/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels May 30, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 30, 2024 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4095 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

In order to resolve Error: This socket has been ended by the other party errors in CI documented in cypress-io/cypress#27552.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 9fedaf0 into openshift:master May 31, 2024
@rhamilto rhamilto deleted the CONSOLE-4095 branch May 31, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@TheRealJon TheRealJon TheRealJon approved these changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@jhadvig jhadvig

@TheRealJon TheRealJon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rhamilto @openshift-ci-robot @jhadvig @TheRealJon