Skip to content

OCPBUGS-33787: deps: bump openshift/api #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Jun 3, 2024
Merged

OCPBUGS-33787: deps: bump openshift/api #907

openshift-merge-bot merged 1 commit into from
Jun 3, 2024

Conversation

@alebedev87
Copy link
Contributor

@alebedev87 alebedev87 commented May 27, 2024 •
edited
Loading

  • Remove all code associated with discontinued v1alpha1 API (webhook)
  • Remove webhook manifests
  • Update client-go to eliminate v1alpha1 dependencies
  • Update dependencies: k8s.io/component-base, k8s.io/apiserver
  • Use ConditionApplyConfiguration for the auth status
  • Vendor generated CRDs

Related PR: #886.

@openshift-ci openshift-ci bot requested review from jhadvig and spadgett May 27, 2024 14:10
@alebedev87 alebedev87 force-pushed the bump-openshift-api branch from e4344d6 to 6aa9e1e Compare May 27, 2024 14:12
@alebedev87 alebedev87 changed the title Update OpenShift API deps: bump openshift/api May 27, 2024
@alebedev87
Copy link
Contributor Author

alebedev87 commented May 27, 2024

/retest

@alebedev87 alebedev87 mentioned this pull request May 27, 2024
Closed
@alebedev87 alebedev87 force-pushed the bump-openshift-api branch 2 times, most recently from c68cc2a to 08edf1a Compare May 28, 2024 20:46
@alebedev87
Copy link
Contributor Author

alebedev87 commented May 29, 2024

/retest

@alebedev87 alebedev87 force-pushed the bump-openshift-api branch from 08edf1a to e5493ce Compare May 29, 2024 10:04
@alebedev87
Copy link
Contributor Author

alebedev87 commented May 29, 2024

Webhook manifests removed

@alebedev87
deps: bump openshift/api
2a8b852 
- Remove all code associated with discontinued v1alpha1 API (webhook)
- Remove webhook manifests
- Update client-go to eliminate v1alpha1 dependencies
- Update dependencies: k8s.io/component-base, k8s.io/apiserver
- Use ConditionApplyConfiguration for the auth status
- Vendor generated CRDs
@alebedev87 alebedev87 force-pushed the bump-openshift-api branch from e5493ce to 2a8b852 Compare May 29, 2024 19:58
@alebedev87
Copy link
Contributor Author

alebedev87 commented May 29, 2024

Rebased from master.

@alebedev87
Copy link
Contributor Author

alebedev87 commented May 30, 2024

/test e2e-aws-console

1 similar comment
@alebedev87
Copy link
Contributor Author

alebedev87 commented May 30, 2024

/test e2e-aws-console

@alebedev87 alebedev87 changed the title deps: bump openshift/api OCPBUGS-33787: deps: bump openshift/api May 30, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 30, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 30, 2024

@alebedev87: This pull request references Jira Issue OCPBUGS-33787, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

  • Remove all code associated with discontinued v1alpha1 API (webhook)
  • Remove webhook manifests
  • Update client-go to eliminate v1alpha1 dependencies
  • Update dependencies: k8s.io/component-base, k8s.io/apiserver
  • Use ConditionApplyConfiguration for the auth status
  • Vendor generated CRDs

Dependent PR: #886.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei May 30, 2024 14:35
jhadvig
jhadvig approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2024
@alebedev87
Copy link
Contributor Author

alebedev87 commented May 30, 2024

e2e-aws-console failures are related to openshift/console#13887.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 30, 2024

/retest-required

Remaining retests: 0 against base HEAD 3e2f479 and 2 for PR HEAD 2a8b852 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 30, 2024

@alebedev87: This pull request references Jira Issue OCPBUGS-33787, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

  • Remove all code associated with discontinued v1alpha1 API (webhook)
  • Remove webhook manifests
  • Update client-go to eliminate v1alpha1 dependencies
  • Update dependencies: k8s.io/component-base, k8s.io/apiserver
  • Use ConditionApplyConfiguration for the auth status
  • Vendor generated CRDs

Related PR: #886.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alebedev87
Copy link
Contributor Author

alebedev87 commented May 31, 2024

/retest

1 similar comment
@alebedev87
Copy link
Contributor Author

alebedev87 commented May 31, 2024

/retest

@alebedev87
Copy link
Contributor Author

alebedev87 commented May 31, 2024

/retest

Wake up.

@jhadvig
Copy link
Member

jhadvig commented May 31, 2024

/woof

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2024

@jhadvig: dog image

Details

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jhadvig
Copy link
Member

jhadvig commented May 31, 2024

/retest

1 similar comment
@alebedev87
Copy link
Contributor Author

alebedev87 commented May 31, 2024

/retest

@alebedev87
Copy link
Contributor Author

alebedev87 commented May 31, 2024

Cluster installation problem:

level=fatal msg=failed to fetch Cluster Infrastructure Variables: failed to fetch dependency of "Cluster Infrastructure Variables": failed to generate asset "Platform Provisioning Check": baseDomain: Invalid value: "origin-ci-int-aws.dev.rhcloud.com": the zone already has record sets for the domain of the cluster: [api.ci-op-t41xx8zp-be832.origin-ci-int-aws.dev.rhcloud.com. (A)]
209
Installer exit with code 1

@alebedev87
Copy link
Contributor Author

alebedev87 commented May 31, 2024

/retest

3 similar comments
@alebedev87
Copy link
Contributor Author

alebedev87 commented Jun 1, 2024

/retest

@alebedev87
Copy link
Contributor Author

alebedev87 commented Jun 1, 2024

/retest

@alebedev87
Copy link
Contributor Author

alebedev87 commented Jun 2, 2024

/retest

@alebedev87
Copy link
Contributor Author

alebedev87 commented Jun 3, 2024

e2e-aws-console is unstable, see the test PR with empty commit which failed 4 times in a row.

@jhadvig
Copy link
Member

jhadvig commented Jun 3, 2024

Overriding since our console integration tests are flaking pretty heavily
/override ci/prow/e2e-aws-console

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2024

@jhadvig: Overrode contexts on behalf of jhadvig: ci/prow/e2e-aws-console

Details

In response to this:

Overriding since our console integration tests are flaking pretty heavily
/override ci/prow/e2e-aws-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2024

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d4bac3a into openshift:master Jun 3, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 3, 2024

@alebedev87: Jira Issue OCPBUGS-33787: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-33787 has not been moved to the MODIFIED state.

Details

In response to this:

  • Remove all code associated with discontinued v1alpha1 API (webhook)
  • Remove webhook manifests
  • Update client-go to eliminate v1alpha1 dependencies
  • Update dependencies: k8s.io/component-base, k8s.io/apiserver
  • Use ConditionApplyConfiguration for the auth status
  • Vendor generated CRDs

Related PR: #886.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 3, 2024

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-operator-container-v4.17.0-202406031013.p0.gd4bac3a.assembly.stream.el9 for distgit openshift-enterprise-console-operator.
All builds following this will include this PR.

@alebedev87 alebedev87 mentioned this pull request Jun 7, 2024
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@spadgett spadgett Awaiting requested review from spadgett

@yapei yapei Awaiting requested review from yapei

Assignees

@jhadvig jhadvig

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alebedev87 @openshift-ci-robot @jhadvig @openshift-bot