Skip to content

[WIP] CONSOLE-4083: Remove Dockerfile.builder and make other container file changes #13830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rhamilto wants to merge 1 commit into from
Closed

[WIP] CONSOLE-4083: Remove Dockerfile.builder and make other container file changes #13830

rhamilto wants to merge 1 commit into from

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented May 8, 2024

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2024
@openshift-ci openshift-ci bot requested review from jhadvig and spadgett May 8, 2024 20:10
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
rhamilto
rhamilto commented May 16, 2024
View reviewed changes
@rhamilto rhamilto changed the title [WIP] Console 4017 [WIP] CONSOLE-4083: Remove Dockerfile.builder and make other container file changes May 16, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 16, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 16, 2024 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4083 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Member Author

rhamilto commented May 16, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 16, 2024 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4083 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rhamilto
rhamilto commented May 30, 2024
View reviewed changes
@rhamilto
Copy link
Member Author

rhamilto commented May 30, 2024

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2024

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@TheRealJon TheRealJon mentioned this pull request May 31, 2024
Closed
jhadvig
jhadvig reviewed Jun 4, 2024
View reviewed changes
Dockerfile.cypress

##################################################
#
# go backend build
Copy link
Member

@jhadvig jhadvig Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it, we wont need to build backend in the this image, since we are testing agains live cluster.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 3, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 3, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2024
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Sep 3, 2024

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rhamilto rhamilto closed this Sep 3, 2024
@rhamilto rhamilto deleted the CONSOLE-4017 branch October 10, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig left review comments

@spadgett spadgett Awaiting requested review from spadgett

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rhamilto @openshift-ci-robot @openshift-bot @openshift-merge-robot @jhadvig