OCPBUGS-33787: Add cluster wide trusted CA bundle to operator #911
Conversation
openshift-ci-robot
added
jira/severity-important
|
@alebedev87: This pull request references Jira Issue OCPBUGS-33787, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The alternative ingress can be provided via the console config API. This commit ensures that health checks to the alternative ingress pass TLS certificate validation even when the TLS certificate has an unknown CA.
alebedev87
force-pushed
the
tolerate-ingress-absence-doc-dns
branch
from
132eddb to
7053619
Compare
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@alebedev87: This pull request references Jira Issue OCPBUGS-33787, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @jhadvig |
| @@ -0,0 +1,16 @@ | |||
| # The network operator is responsible for injecting | |||
| # the trusted ca bundle into this configmap. | |||
There was a problem hiding this comment.
So the operator already create a trusted-ca-bundle CM, check: https://github.com/openshift/console-operator/blob/master/pkg/console/subresource/configmap/trusted_ca.go#L22
which is then used in sync_400, which is then passed to the console deployment
There was a problem hiding this comment.
Right. As we discussed in Slack. The two configmaps are from different namespaces as since they are consumed as volume mounts we cannot consume the operator's one in the operand's namespace.
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87, jhadvig The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@alebedev87: Jira Issue OCPBUGS-33787: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-33787 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-console-operator-container-v4.17.0-202406212042.p0.g7f3a07b.assembly.stream.el9 for distgit openshift-enterprise-console-operator. |
4 participants
The alternative ingress can be provided via the console config API. This PR ensures that health checks to the alternative ingress pass TLS certificate validation even when the TLS certificate has an unknown CA.
Additionally, this PR would help with the proxy support similar to how it was done in the cluster ingress operator.