Skip to content

Add ConsoleYAMLSample CRD as part of the console extensions#99

Closed
jhadvig wants to merge 2 commits intoopenshift:masterfrom
jhadvig:yaml_sample
Closed

Add ConsoleYAMLSample CRD as part of the console extensions#99
jhadvig wants to merge 2 commits intoopenshift:masterfrom
jhadvig:yaml_sample

Conversation

@jhadvig
Copy link
Copy Markdown
Member

@jhadvig jhadvig commented Oct 11, 2019

Wasn't really sure what to put the the apiVersion and kind description, since it's "TBD" in @rhamilto PR. For now I've add apiVersion and kind description to the default we use in all of our CRDs.

@spadgett FYI

/assign @sttts

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2019
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jhadvig
To complete the pull request process, please assign sttts
You can assign the PR to them by writing /assign @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Copy Markdown
Member

@jhadvig I believe this goes to openshift/api first and the CRD itself is generated

cc @benjaminapetersen

@benjaminapetersen
Copy link
Copy Markdown
Contributor

And just a note we will likely have to do something like this:
https://github.com/openshift/origin/pull/23382/files
to get tests to pass.

@damemi
Copy link
Copy Markdown
Contributor

damemi commented Oct 15, 2019

The CRD generator will generate only the validation section (make update-codegen). As long as the API change has been bumped here (make update-deps), then just running the generator now should fill out the rest of the CRD

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 15, 2019
@jhadvig jhadvig changed the title [WIP] Add ConsoleYAMLSample CRD as part of the console extensions Add ConsoleYAMLSample CRD as part of the console extensions Oct 15, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2019
@jhadvig
Copy link
Copy Markdown
Member Author

jhadvig commented Oct 15, 2019

@damemi PR updated. PTAL

@openshift-ci-robot
Copy link
Copy Markdown

@jhadvig: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/verify cf41c03 link /test verify
ci/prow/e2e-aws-upgrade cf41c03 link /test e2e-aws-upgrade
ci/prow/e2e-aws cf41c03 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@damemi
Copy link
Copy Markdown
Contributor

damemi commented Oct 16, 2019

/hold
We're moving these CRDs to be consumed by this operator from openshift/api right now, and don't want to add more to the list until the current ones are already sorted out. See #102

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2019
@benjaminapetersen
Copy link
Copy Markdown
Contributor

We may be able to close this one since the other will contain it + the rest.

@benjaminapetersen
Copy link
Copy Markdown
Contributor

/close

We will include this in
openshift/console-operator#314

@openshift-ci-robot
Copy link
Copy Markdown

@benjaminapetersen: Closed this PR.

Details

In response to this:

/close

We will include this in
openshift/console-operator#314

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants