Add ConsoleYAMLSample CRD as part of the console extensions#99
Add ConsoleYAMLSample CRD as part of the console extensions#99jhadvig wants to merge 2 commits intoopenshift:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jhadvig The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@jhadvig I believe this goes to openshift/api first and the CRD itself is generated |
|
And just a note we will likely have to do something like this: |
|
The CRD generator will generate only the validation section ( |
|
@damemi PR updated. PTAL |
|
@jhadvig: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold |
|
We may be able to |
|
/close We will include this in |
|
@benjaminapetersen: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Wasn't really sure what to put the the
apiVersionandkinddescription, since it's "TBD" in @rhamilto PR. For now I've addapiVersionandkinddescription to the default we use in all of our CRDs.@spadgett FYI
/assign @sttts