Skip to content

Revert "Migrate console extensions CRDs from console-operator"#103

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
benjaminapetersen:revert-95-console/extensions
Oct 17, 2019
Merged

Revert "Migrate console extensions CRDs from console-operator"#103
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
benjaminapetersen:revert-95-console/extensions

Conversation

@benjaminapetersen
Copy link
Copy Markdown
Contributor

@benjaminapetersen benjaminapetersen commented Oct 16, 2019 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 16, 2019
This was referenced Oct 16, 2019
Closed
Merged
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Oct 17, 2019

/lgtm
/retest

/hold cancel

If this can pass CI, then it's good enough to be in master while you get them back at the right levels.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2019
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Oct 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2019
@spadgett
Copy link
Copy Markdown
Member

spadgett commented Oct 17, 2019

/hold
this will break console merge queue, can you give us just a little time to fix?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2019
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Oct 17, 2019

/hold
this will break console merge queue, can you give us just a little time to fix?

Sure. Let's call it tomorrow AM. Keeping these in a structural risk for people trying to use them an effectively pinning usage here. We've seen it happen with other CRDs and typos we've had. At a certain point, we will have to correct the signal to the rest of product/payload even if some eggs break.

@benjaminapetersen
Copy link
Copy Markdown
Contributor Author

benjaminapetersen commented Oct 17, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2019
@openshift-merge-robot openshift-merge-robot merged commit 667ec0e into openshift:master Oct 17, 2019
@benjaminapetersen benjaminapetersen deleted the revert-95-console/extensions branch October 17, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@sttts sttts Awaiting requested review from sttts

Assignees

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@benjaminapetersen @deads2k @openshift-ci-robot @spadgett @openshift-merge-robot