OTA-559: Migrate to (*Manifest).Include(..., overrides) #934
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@wking: This pull request references OTA-559 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
wking
force-pushed
the
library-go-overrides
branch
7 times, most recently
from
3e79b9e to
8bfe105
Compare
openshift-merge-robot
added
the
needs-rebase
Shifting to the centralized logic from openshift/library-go@087d2eb13a (pkg/manifest: Add 'overrides' handling, 2023-04-18, openshift/library-go#1502).
Picking up openshift/library-go@087d2eb13a (pkg/manifest: Add 'overrides' handling, 2023-04-18, openshift/library-go#1502). Generated with: $ go get -u github.com/openshift/library-go $ go mod tidy $ go mod vendor $ git add -A go.* vendor using: $ go version go version go1.19.5 linux/amd64
Addressing [1] and similar: lib/resourceapply/apps.go:34:14: SA1019: pointer.BoolPtr is deprecated: Use Bool instead. (staticcheck) modified := pointer.BoolPtr(false) ^ Generated with: $ sed -i 's/pointer.BoolPtr/pointer.Bool/' lib/resourceapply/*.go [1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-version-operator/934/pull-ci-openshift-cluster-version-operator-master-lint/1651287295325638656#1:build-log.txt%3A34
Addressing [1] and similar:
pkg/payload/payload.go:303:13: SA1019: sets.String is deprecated: use generic Set instead. new ways: s1 := Set[string]{} s2 := New[string]() (staticcheck)
skipFiles sets.String
^
[1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-version-operator/934/pull-ci-openshift-cluster-version-operator-master-lint/1651287295325638656#1:build-log.txt%3A43
Addressing [1] and similar: pkg/autoupdate/autoupdate.go:73:39: Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck) cvInformer.Informer().AddEventHandler(ctrl.eventHandler()) ^ In a few cases, this triggered additional plumbing changes to bubble the errors up the call stack. [1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-version-operator/934/pull-ci-openshift-cluster-version-operator-master-lint/1651287295325638656#1:build-log.txt%3A43
wking
force-pushed
the
library-go-overrides
branch
from
8bfe105 to
fdf3419
Compare
openshift-merge-robot
removed
the
needs-rebase
|
@wking: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Shifting to the centralized logic from openshift/library-go@087d2eb13a (openshift/library-go#1502).
Manual
pkg/updates, followed by an automated vendor bump generated with:using: