Bug 1841239: Avoid pre-creating clusteroperators that should be excluded #376

csrwng · 2020-05-28T17:14:47Z

Backport of #370

openshift-ci-robot · 2020-05-28T17:14:51Z

@csrwng: This pull request references Bugzilla bug 1841239, which is invalid:

expected dependent Bugzilla bug 1838872 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1841239: [release-4.4] Avoid pre-creating clusteroperators that should be excluded

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2020-05-28T18:17:09Z

/lgtm

Looks like a clean backport to me. Was there a reason you didn't comment with /cherrypick release-4.4 in #370 and let the bot handle the backport bug and PR for you?

wking · 2020-05-28T18:33:22Z

/hold

Unifying with #348 per this comment makes sense to me.

csrwng · 2020-05-28T18:47:47Z

Looks like a clean backport to me. Was there a reason you didn't comment with /cherrypick release-4.4 in #370 and let the bot handle the backport bug and PR for you?

Premature optimization :) I thought the patch wouldn't apply cleanly.

Unifying with #348 per this comment makes sense to me.

agree

jottofar · 2020-05-28T19:34:03Z

Unifying with #348 per this comment makes sense to me as well.

csrwng · 2020-05-28T20:01:33Z

@wking @jottofar now included the #348 commit in this one (have no idea how to change a cherry-pick PR)

csrwng · 2020-05-28T21:32:43Z

/test e2e-aws

wking · 2020-05-28T22:27:18Z

Hrm, #348 never had a backing bug. Which probably means we need to grow the QE verification scope on this series' 4.5 bug so they confirm that functionality is working as expected too. Or are we just going to assume "create ClusterOperators early" works and not cover it in QE for 4.5 or 4.4?

Also, I'm not sure why the update job failed. Is there a list of failing vs. flaky/optional failures in the build log that I'm just missing?

csrwng · 2020-05-28T22:32:32Z

Or are we just going to assume "create ClusterOperators early" works and not cover it in QE for 4.5 or 4.4?

I think the right thing to do is to make the bug about introducing the "create clusteroperators early" functionality in 4.4. The other part is just a corollary fix so that it works properly for ROKS as well. Not sure how that works as far as depencies go though. There was no BZ to introduce the function in 4.5, but I think the 4.4 bug requires a 4.5 bug to exist.

csrwng · 2020-05-28T22:57:50Z

[It] [Top Level] [Feature:Platform] ClusterOperators should define at least one namespace in their lists of related objects [Suite:openshift/conformance/parallel]
  /go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/test/extended/operators/clusteroperators.go:54
May 28 22:12:28.385: INFO: Running AfterSuite actions on all nodes
May 28 22:12:28.385: INFO: Running AfterSuite actions on node 1
fail [github.com/openshift/origin/test/extended/operators/clusteroperators.go:57]: ClusterOperator: machine-config

Looks like this is missing a backport of openshift/machine-config-operator#1566

sdodson · 2020-05-29T00:33:01Z

Just posted a quick note to bug 1841239, QE still has to verify the 4.5 bug anyway and I'm sure once they do that they'll understand everything that's going on in this PR and the linked bug.

sdodson · 2020-05-29T00:37:06Z

Looks like this is missing a backport of openshift/machine-config-operator#1566

Hmm, starting to think we should call in @deads2k to round up all the follow up work that should come along with backporting the CVO pre-fill? This is just docs but it's linked from the original PR too #363

deads2k · 2020-06-17T19:35:18Z

looks faithful. I don't feel strongly about a readme

/lgtm

deads2k · 2020-06-17T19:36:37Z

/hold

hold for openshift/machine-config-operator#1764

openshift-ci-robot · 2020-06-22T13:33:52Z

@sdodson: This pull request references Bugzilla bug 1841239, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.z) matches configured target release for branch (4.4.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1838872 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1838872 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdodson · 2020-06-22T13:35:00Z

We still have no feature-request bug to hang this backport on though, right? I don't think we should pull this back to 4.4 hung on a bug about how the initial 4.5 feature (which landed without a bug) was fixed for ROKS. 4.4 isn't broken at all on ROKS without this PR, and will still not be broken once we land this PR. Can we grow a new series about pre-created cluster-operators, so QE can verify that that is working for 4.5, and then hang this PR on a 4.4 backport of that one?

We've provided QE notes in the bug that I believe explain the situation sufficiently. If they have questions I expect them to ask.

sdodson · 2020-06-28T13:56:51Z

/hold cancel

openshift-bot · 2020-06-28T14:01:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-28T14:14:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-28T14:27:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-28T14:40:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-28T14:53:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

wking · 2020-06-28T15:00:13Z

/hold

Building github.com/openshift/cluster-version-operator (v1.0.0-204-gc1c8d84d-dirty)
# github.com/openshift/cluster-version-operator/pkg/cvo
pkg/cvo/sync_worker.go:621:8: undefined: contextIsCancelled
pkg/cvo/sync_worker.go:622:15: cr.CancelError undefined (type *consistentReporter has no field or method CancelError)

The must-gather and insights operator depend on cluster operators and related objects in order to identify resources to create. Because cluster operators are delegated to the operator install and upgrade failures of new operators can fail to gather the requisite info if the cluster degrades before those steps. Add a new selective Precreating install mode and do a single pass over all cluster operators in the payload without retries at the beginning of an initializing or upgrading sync pass to attempt to create the ClusterOperators if they don't exist. If we succeed at creating the object, try exactly once to update status so that relatedObjects can be set.

csrwng · 2020-06-29T17:56:14Z

rebased, fixed

csrwng · 2020-07-14T13:08:47Z

/test images

sdodson · 2020-07-15T00:35:35Z

/hold cancel

deads2k · 2020-08-25T13:28:56Z

/lgtm

openshift-ci-robot · 2020-08-25T13:29:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, deads2k, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

eparis · 2020-09-10T23:27:36Z

/bugzilla refresh

openshift-ci-robot · 2020-09-10T23:27:40Z

@eparis: This pull request references Bugzilla bug 1841239, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.z) matches configured target release for branch (4.4.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1838872 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1838872 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-09-10T23:57:46Z

@csrwng: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp	`44b7cb9`	link	`/test e2e-gcp`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-09-11T21:53:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-09-12T00:29:57Z

@csrwng: All pull requests linked via external trackers have merged:

openshift/cluster-version-operator#376

Bugzilla bug 1841239 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1841239: Avoid pre-creating clusteroperators that should be excluded

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 28, 2020

openshift-ci-robot requested review from abhinavdahiya and sdodson May 28, 2020 17:15

csrwng mentioned this pull request May 28, 2020

[release-4.4] cvo: When installing or upgrading, fast-fill cluster-operators #348

Closed

wking changed the title ~~Bug 1841239: [release-4.4] Avoid pre-creating clusteroperators that should be excluded~~ Bug 1841239: Avoid pre-creating clusteroperators that should be excluded May 28, 2020

openshift-ci-robot assigned wking May 28, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 28, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2020

csrwng force-pushed the fix_exclude_clusteroperators_44 branch from aadb13e to e4e771c Compare May 28, 2020 19:59

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 28, 2020

sdodson mentioned this pull request May 29, 2020

create all clusteroperators in the CVO payload immediately openshift/enhancements#149

Merged

eparis mentioned this pull request Jun 5, 2020

Bug 1829645: add relatedobjects for immediate creation by CVO openshift/cluster-etcd-operator#315

Merged

openshift-ci-robot assigned deads2k Jun 17, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 22, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2020

smarterclayton and others added 2 commits June 29, 2020 13:52

Avoid pre-creating clusteroperators that should be excluded

44b7cb9

csrwng force-pushed the fix_exclude_clusteroperators_44 branch from e4e771c to 44b7cb9 Compare June 29, 2020 17:55

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2020

eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 10, 2020

openshift-merge-robot merged commit 9515b23 into openshift:release-4.4 Sep 12, 2020

Bug 1841239: Avoid pre-creating clusteroperators that should be excluded #376

Bug 1841239: Avoid pre-creating clusteroperators that should be excluded #376

Uh oh!

Conversation

csrwng commented May 28, 2020

Uh oh!

openshift-ci-robot commented May 28, 2020

Uh oh!

wking commented May 28, 2020

Uh oh!

wking commented May 28, 2020

Uh oh!

csrwng commented May 28, 2020

Uh oh!

jottofar commented May 28, 2020

Uh oh!

csrwng commented May 28, 2020

Uh oh!

csrwng commented May 28, 2020

Uh oh!

wking commented May 28, 2020

Uh oh!

csrwng commented May 28, 2020

Uh oh!

csrwng commented May 28, 2020

Uh oh!

sdodson commented May 29, 2020

Uh oh!

sdodson commented May 29, 2020

Uh oh!

deads2k commented Jun 17, 2020

Uh oh!

deads2k commented Jun 17, 2020

Uh oh!

openshift-ci-robot commented Jun 22, 2020

Uh oh!

sdodson commented Jun 22, 2020

Uh oh!

sdodson commented Jun 28, 2020

Uh oh!

openshift-bot commented Jun 28, 2020

Uh oh!

openshift-bot commented Jun 28, 2020

Uh oh!

openshift-bot commented Jun 28, 2020

Uh oh!

openshift-bot commented Jun 28, 2020

Uh oh!

openshift-bot commented Jun 28, 2020

Uh oh!

wking commented Jun 28, 2020

Uh oh!

csrwng commented Jun 29, 2020

Uh oh!

csrwng commented Jul 14, 2020

Uh oh!

sdodson commented Jul 15, 2020

Uh oh!

deads2k commented Aug 25, 2020

Uh oh!

openshift-ci-robot commented Aug 25, 2020

Uh oh!

eparis commented Sep 10, 2020

Uh oh!

openshift-ci-robot commented Sep 10, 2020

Uh oh!

openshift-ci-robot commented Sep 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Sep 11, 2020

Uh oh!

openshift-ci-robot commented Sep 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

openshift-ci-robot commented Sep 10, 2020 •

edited

Loading