Skip to content

[release-4.4] cvo: When installing or upgrading, fast-fill cluster-operators #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
openshift-cherrypick-robot wants to merge 1 commit into from
Closed

[release-4.4] cvo: When installing or upgrading, fast-fill cluster-operators #348

openshift-cherrypick-robot wants to merge 1 commit into from

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Apr 15, 2020

This is an automated cherry-pick of #318

/assign deads2k

@smarterclayton
cvo: When installing or upgrading, fast-fill cluster-operators
a2eeb87 
The must-gather and insights operator depend on cluster operators
and related objects in order to identify resources to create. Because
cluster operators are delegated to the operator install and upgrade
failures of new operators can fail to gather the requisite info if
the cluster degrades before those steps.

Add a new selective Precreating install mode and do a single pass
over all cluster operators in the payload without retries at the beginning
of an initializing or upgrading sync pass to attempt to create the
ClusterOperators if they don't exist. If we succeed at creating the
object, try exactly once to update status so that relatedObjects can
be set.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 15, 2020

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.4] cvo: When installing or upgrading, fast-fill cluster-operators

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 15, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 15, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign crawford
You can assign the PR to them by writing /assign @crawford in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hexfusion
Copy link

hexfusion commented May 8, 2020

/retest

@sdodson I think we want to get this in 4.4 right?

@sdodson
Copy link
Member

sdodson commented May 8, 2020

@sdodson I think we want to get this in 4.4 right?

Yeah, has anyone verified it produces the expected outcomes in 4.5?

@hexfusion hexfusion mentioned this pull request May 18, 2020
Merged
@hexfusion
Copy link

hexfusion commented May 27, 2020

@sdodson I think we want to get this in 4.4 right?

Yeah, has anyone verified it produces the expected outcomes in 4.5?

@sdodson verified in 4.5 for cluster-etcd-operator[1]

[1]https://bugzilla.redhat.com/show_bug.cgi?id=1829644

@hexfusion
Copy link

hexfusion commented May 27, 2020

/test e2e-aws

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 27, 2020

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws a2eeb87 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson
Copy link
Member

sdodson commented May 27, 2020

@csrwng Did you run into problems with this change and hypershift? Do we need to backport a fix along with this PR?

@csrwng
Copy link
Contributor

csrwng commented May 27, 2020

@sdodson yes I did, and submitted a PR to fix here: #370
Should update today based on @wking's comment.

@sdodson
Copy link
Member

sdodson commented May 27, 2020

/hold
This will break hypershift. We should make sure to include the fixes from #370 before we backport this.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2020
@csrwng
Copy link
Contributor

csrwng commented May 28, 2020

Backport of 4.4 fix: #376

@sdodson
Copy link
Member

sdodson commented May 28, 2020

/assign @wking @jottofar
PTAL, however you'd prefer we land this and #376 at the same time or atleast within the same merge window works for me. It's probably easier to bring all the commits into one PR though.

@wking wking mentioned this pull request May 28, 2020
Merged
@wking
Copy link
Member

wking commented May 28, 2020

Getting carried by #376

/close

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 28, 2020

@wking: Closed this PR.

Details

In response to this:

Getting carried by #376

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdodson sdodson Awaiting requested review from sdodson

@wking wking Awaiting requested review from wking

Assignees

@wking wking

@deads2k deads2k

@jottofar jottofar

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@openshift-cherrypick-robot @openshift-ci-robot @hexfusion @sdodson @csrwng @wking @deads2k @jottofar @smarterclayton