Bug 1838872: Avoid pre-creating clusteroperators that should be excluded

[csrwng]

In 4.5 we added code to precreate cluster-operator resources. However, in the precreate loop we're not checking whether resources should be excluded based on annotation. This adds a check to the loop so we can preserve pre-4.5 behavior.

[csrwng]

@abhinavdahiya ptal

[openshift-ci-robot]

@csrwng: This pull request references Bugzilla bug 1838872, which is invalid:

• expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1838872: Avoid pre-creating clusteroperators that should be excluded

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[csrwng]

/bugzilla refresh

[openshift-ci-robot]

@csrwng: This pull request references Bugzilla bug 1838872, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[csrwng]

/retest

[wking]

Can we handle exclusions when we load manifests? That way we can't forget to exclude things later on.

[csrwng]

Can we handle exclusions when we load manifests? That way we can't forget to exclude things later on.

Makes sense, will make the change

[csrwng]

@wking updated

[wking]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@csrwng: All pull requests linked via external trackers have merged: openshift/cluster-version-operator#370. Bugzilla bug 1838872 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1838872: Avoid pre-creating clusteroperators that should be excluded

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.