OCPBUGS-54491: sync Azure File permissions with upstream docs

[RomanBednar]

If users configure a storage class with networkEndpointType: privateEndpoint parameter CSI driver will fail to provision a volume due to missing permissions.

I've cross checked the OCPBUGS-54491 bug report with upstream documentation to see what we miss and also noticed a few more that were also missing upstream when testing the private endpoints manually. After discussing this with upstream the list was extended with the missing ones: kubernetes-sigs/azurefile-csi-driver#2513

This CredentialsRequest object is used when installing or upgrading cluster, by extracting it from payload and passing it to ccoctl which creates Azure roles with the permissions listed. This might result in granting more privileges than most users need.

Alternatively we could drop this change and only document the process, which would require additional manual step for users intending to use private endpoints.

[openshift-ci-robot]

@RomanBednar: This pull request references Jira Issue OCPBUGS-54491, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

If users configure a storage class with networkEndpointType: privateEndpoint parameter CSI driver will fail to provision a volume due to missing permissions.

I've cross checked the OCPBUGS-54491 bug report with upstream documentation to see what we miss and also noticed a few more that were also missing upstream when testing the private endpoints manually. After discussing this with upstream the list was extended with the missing ones: kubernetes-sigs/azurefile-csi-driver#2513

This CredentialsRequest object is used when installing or upgrading cluster, by extracting it from payload and passing it to ccoctl which creates Azure roles with the permissions listed. This might result in granting more privileges than most users need.

Alternatively we could drop this change and only document the process, which would require additional manual step for users intending to use private endpoints.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [RomanBednar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[RomanBednar]

/jira refresh

[openshift-ci-robot]

@RomanBednar: This pull request references Jira Issue OCPBUGS-54491, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[RomanBednar]

/retest-required

[jsafrane]

This might result in granting more privileges than most users need.

I personally prefer following upstream than explaining customers what permissions they need and when.
/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 1c47e71 and 2 for PR HEAD 641aabe in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 1c47e71 and 2 for PR HEAD 641aabe in total

[openshift-ci]

@RomanBednar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@RomanBednar: Jira Issue OCPBUGS-54491: All pull requests linked via external trackers have merged:

• openshift/cluster-storage-operator#576

Jira Issue OCPBUGS-54491 has been moved to the MODIFIED state.

Details

In response to this:

If users configure a storage class with networkEndpointType: privateEndpoint parameter CSI driver will fail to provision a volume due to missing permissions.

I've cross checked the OCPBUGS-54491 bug report with upstream documentation to see what we miss and also noticed a few more that were also missing upstream when testing the private endpoints manually. After discussing this with upstream the list was extended with the missing ones: kubernetes-sigs/azurefile-csi-driver#2513

This CredentialsRequest object is used when installing or upgrading cluster, by extracting it from payload and passing it to ccoctl which creates Azure roles with the permissions listed. This might result in granting more privileges than most users need.

Alternatively we could drop this change and only document the process, which would require additional manual step for users intending to use private endpoints.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: cluster-storage-operator
This PR has been included in build ose-cluster-storage-operator-container-v4.20.0-202504230126.p0.g82d8d42.assembly.stream.el9.
All builds following this will include this PR.