OCPBUGS-55182: Add required Microsoft.Network/natGateways/join/action permission

[cadenmarchese]

According to linked access checks in Azure, if the user has configured a nat gateway on their subnet, the network resource provider will also check for Microsoft.Network/natGateways/join/action when FSO attempts to execute a Microsoft.Network/virtualNetworks/subnets/write operation. Since the FSO credentialsrequest requires Microsoft.Network/virtualNetworks/subnets/write, and many users also bring a nat gateway, Microsoft.Network/natGateways/join/action is also required.

[cadenmarchese]

/retest-required

[jsafrane]

@cadenmarchese can you please post a PR upstream (here)? We don't want to diverge from upstream permissions, as it would be just us to maintain them.

[cadenmarchese]

@jsafrane thanks, I went ahead and opened a PR there: kubernetes-sigs/azurefile-csi-driver#2495

[jsafrane]

Now that the upstream PR is merged, I can see there were some more additions. Do we need them in OCP?

[cadenmarchese]

@jsafrane that depends - does OCP support configuring those additional resources (serviceEndpointPolicies, networkIntentPolicies, ipamPools) on the subnet?

[openshift-ci-robot]

@cadenmarchese: This pull request references Jira Issue OCPBUGS-55182, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

According to linked access checks in Azure, if the user has configured a nat gateway on their subnet, the network resource provider will also check for Microsoft.Network/natGateways/join/action when FSO attempts to execute a Microsoft.Network/virtualNetworks/subnets/write operation. Since the FSO credentialsrequest requires Microsoft.Network/virtualNetworks/subnets/write, and many users also bring a nat gateway, Microsoft.Network/natGateways/join/action is also required.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cadenmarchese
Once this PR has been reviewed and has the lgtm label, please assign tsmetana for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@cadenmarchese: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	9f2f681	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-manual-oidc	9f2f681	link	false	/test e2e-gcp-manual-oidc
ci/prow/e2e-aws-csi	9f2f681	link	true	/test e2e-aws-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[RomanBednar]

@cadenmarchese We don't document all options for every driver as there's too many, on the other hand we do support them to some extent.

I've just noticed this PR but already synced the permissions in scope of #576 - can we close this?

[openshift-merge-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[cadenmarchese]

Closing as this was addressed in #576 already. Thanks @RomanBednar

[openshift-ci-robot]

@cadenmarchese: This pull request references Jira Issue OCPBUGS-55182. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

According to linked access checks in Azure, if the user has configured a nat gateway on their subnet, the network resource provider will also check for Microsoft.Network/natGateways/join/action when FSO attempts to execute a Microsoft.Network/virtualNetworks/subnets/write operation. Since the FSO credentialsrequest requires Microsoft.Network/virtualNetworks/subnets/write, and many users also bring a nat gateway, Microsoft.Network/natGateways/join/action is also required.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.