OCPBUGS-54491: sync Azure File permissions with upstream docs #2 #578

RomanBednar · 2025-04-28T11:13:19Z

This is a fixup for #576 - I've missed two lines in upstream issue: kubernetes-sigs/azurefile-csi-driver#2512 (comment)

openshift-ci-robot · 2025-04-28T11:13:27Z

@RomanBednar: This pull request references Jira Issue OCPBUGS-54491, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a fixup for #576 - I've missed two lines in upstream issue: kubernetes-sigs/azurefile-csi-driver#2512 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-04-28T11:13:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [RomanBednar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

RomanBednar · 2025-05-05T09:01:42Z

/assign @jsafrane

for review

Phaow · 2025-05-07T05:43:08Z

manifests/03_credentials_request_azure_file.yaml

@@ -31,7 +31,9 @@ spec:
      - 'Microsoft.Network/virtualNetworks/subnets/*/read'


@RomanBednar Better to also remove 'Microsoft.Network/virtualNetworks/subnets/*/read', it is duplicated with 'Microsoft.Network/virtualNetworks/subnets/read'.
I filed upstream PR correct it ->
kubernetes-sigs/azurefile-csi-driver#2557

@Phaow Good catch, I reflected the upstream change here.

Phaow · 2025-05-07T12:43:57Z

/retest-required

openshift-ci · 2025-05-07T14:13:11Z

@RomanBednar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`07d7b5a`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/e2e-openstack-parallel	`07d7b5a`	link	false	`/test e2e-openstack-parallel`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

duanwei33 · 2025-05-15T08:36:20Z

The pre-merge verification passed on 4.19.0-0-2025-05-15-053327-test-ci-ln-txql572-latest.

/label qe-approved
/label cherry-pick-approved

openshift-ci-robot · 2025-05-15T08:36:30Z

@RomanBednar: This pull request references Jira Issue OCPBUGS-54491, which is invalid:

expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.19.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

This is a fixup for #576 - I've missed two lines in upstream issue: kubernetes-sigs/azurefile-csi-driver#2512 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

RomanBednar · 2025-05-15T09:11:06Z

/jira refresh

openshift-ci-robot · 2025-05-15T09:11:11Z

@RomanBednar: This pull request references Jira Issue OCPBUGS-54491, which is invalid:

expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.19.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

RomanBednar · 2025-05-15T09:12:44Z

/jira refresh

openshift-ci-robot · 2025-05-15T09:12:50Z

@RomanBednar: This pull request references Jira Issue OCPBUGS-54491, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.0) matches configured target version for branch (4.20.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

RomanBednar · 2025-05-15T09:13:52Z

/cherry-pick release-4.19

openshift-cherrypick-robot · 2025-05-15T09:13:56Z

@RomanBednar: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

dfajmon · 2025-05-15T11:26:55Z

/lgtm

openshift-ci-robot · 2025-05-15T11:32:54Z

@RomanBednar: Jira Issue OCPBUGS-54491: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-54491 has been moved to the MODIFIED state.

Details

In response to this:

This is a fixup for #576 - I've missed two lines in upstream issue: kubernetes-sigs/azurefile-csi-driver#2512 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2025-05-15T11:33:41Z

@RomanBednar: new pull request created: #580

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-bot · 2025-05-15T14:22:22Z

[ART PR BUILD NOTIFIER]

Distgit: cluster-storage-operator
This PR has been included in build ose-cluster-storage-operator-container-v4.20.0-202505151347.p0.gd8e9920.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci bot requested review from mandre and tsmetana April 28, 2025 11:13

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2025

openshift-ci bot assigned jsafrane May 5, 2025

Phaow reviewed May 7, 2025

View reviewed changes

fixup - sync Azure File permissions with upstream docs

07d7b5a

RomanBednar force-pushed the OCPBUGS-54491 branch from 382f2af to 07d7b5a Compare May 7, 2025 09:02

openshift-ci bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels May 15, 2025

openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 15, 2025

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 15, 2025

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 15, 2025

openshift-ci bot assigned dfajmon May 15, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2025

openshift-merge-bot bot merged commit d8e9920 into openshift:main May 15, 2025
18 of 20 checks passed

openshift-cherrypick-robot mentioned this pull request May 15, 2025

[release-4.19] OCPBUGS-56253: sync Azure File permissions with upstream docs #2 #580

Merged

		@@ -31,7 +31,9 @@ spec:
		- 'Microsoft.Network/virtualNetworks/subnets/*/read'

OCPBUGS-54491: sync Azure File permissions with upstream docs #2 #578

OCPBUGS-54491: sync Azure File permissions with upstream docs #2 #578

Uh oh!

Conversation

RomanBednar commented Apr 28, 2025

Uh oh!

openshift-ci-robot commented Apr 28, 2025

Uh oh!

openshift-ci bot commented Apr 28, 2025

Uh oh!

RomanBednar commented May 5, 2025

Uh oh!

Phaow May 7, 2025

Choose a reason for hiding this comment

Uh oh!

RomanBednar May 7, 2025

Choose a reason for hiding this comment

Uh oh!

Phaow commented May 7, 2025

Uh oh!

openshift-ci bot commented May 7, 2025

Uh oh!

duanwei33 commented May 15, 2025

Uh oh!

openshift-ci-robot commented May 15, 2025

Uh oh!

RomanBednar commented May 15, 2025

Uh oh!

openshift-ci-robot commented May 15, 2025

Uh oh!

RomanBednar commented May 15, 2025

Uh oh!

openshift-ci-robot commented May 15, 2025

Uh oh!

RomanBednar commented May 15, 2025

Uh oh!

openshift-cherrypick-robot commented May 15, 2025

Uh oh!

dfajmon commented May 15, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented May 15, 2025

Uh oh!

openshift-cherrypick-robot commented May 15, 2025

Uh oh!

openshift-bot commented May 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants