STOR-1334: update storage operator to read featuregates from API

[jsafrane]

A second attempt after #368. Now read the feature gates from API both in standalone cluster and in hypershift - it has correct featuregate.status.

@openshift/storage

[openshift-ci-robot]

@jsafrane: This pull request references STOR-1334 which is a valid jira issue.

Details

In response to this:

A second attempt after #368. Now read the feature gates from API both in standalone cluster and in hypershift - it has correct featuregate.status.

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jsafrane]

/retest

[jsafrane]

/test hypershift-aws-e2e-external

[openshift-ci]

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ovn-vsphere	122bfb3	link	false	/test e2e-ovn-vsphere

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[gnufied]

I feel like CurrentFeatureGates should block until it has done syncing the loop. Is 1 minute reasonable time btw?

[jsafrane]

The select above is the blocking sync to get feature gates.

With exit() after 1 minute, kubelet will start exp. backoff restarting the Pod, so I think it's good enough. A cluster without FeatureGate is not a very healthy one.

[gnufied]

@deads2k what do you think about call to CurrentFeatures blocking . I think that this code leaks internal details of featuregateAccess object. We can clean this up in a follow up, if we all agree to it.

[gnufied]

/lgtm

[jsafrane]

/label px-approved
/label docs-approved

[duanwei33]

I built standalone and hypershift hosted cluster to verify:
In standalone cluster, after enabling the TechPreviewNoUpgrade, CSIDriverSharedResource is installed successfully shortly.
In hypershift hosted cluster, storage CO is healthy, I was trying to enable the TechPreviewNoUpgrade, but seems the CVO doesn't work well and CSIDriverSharedResource is not enabled actually from FeatureGate.status.featureGates as below:

spec:
  featureSet: TechPreviewNoUpgrade
status:
  featureGates:
  - disabled:
    - name: AdmissionWebhookMatchConditions
    - name: AzureWorkloadIdentity
    - name: BuildCSIVolumes
    - name: CSIDriverSharedResource
    - name: DynamicResourceAllocation
    - name: EventedPLEG
    - name: ExternalCloudProvider
    - name: ExternalCloudProviderAzure
    - name: ExternalCloudProviderGCP
    - name: GCPLabelsTags
    - name: GatewayAPI
    - name: InsightsConfigAPI
    - name: MachineAPIProviderOpenStack
    - name: MatchLabelKeysInPodTopologySpread
    - name: MaxUnavailableStatefulSet
    - name: NodeSwap
    - name: PDBUnhealthyPodEvictionPolicy
    - name: PrivateHostedZoneAWS
    - name: RetroactiveDefaultStorageClass
    - name: SigstoreImageVerification
    enabled:
    - name: AlibabaPlatform
    - name: OpenShiftPodSecurityAdmission

Looks like not storage issue, will take further check on this.

[duanwei33]

My bad, the featuregate need to be set in management cluster hostedcluster.spec.configuration, and CSIDriverSharedResource is installed successfully in the hosted cluster after the setting. So PR looks good based on the test above from QE side.

[duanwei33]

/label qe-approved

[deepsm007]

/label jira/valid-bug