Skip to content

Conversation

@wongma7
Copy link

@wongma7 wongma7 commented Dec 4, 2018

changes to make build w/ new Dockerfile work:

  • build go-bindata so it can be used from in build container
  • move contents of old manifests/ to assets/ (the StorageClass yamls)
  • put operator yamls & image-references into new manifests/
  • replace quay.io/openshift/cluster-storage-operator with openshift/origin-cluster-storage-operator:latest

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 4, 2018
@wongma7
Copy link
Author

wongma7 commented Dec 4, 2018

/lgtm

@openshift-ci-robot
Copy link
Contributor

@wongma7: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wongma7 wongma7 added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 4, 2018
@wongma7 wongma7 merged commit 89ea9c3 into openshift:master Dec 4, 2018
gnufied pushed a commit to gnufied/cluster-storage-operator that referenced this pull request Dec 4, 2019
gnufied pushed a commit to gnufied/cluster-storage-operator that referenced this pull request Dec 4, 2019
…kargs-day-1

Update Proposal Method 2 for Day1 kargs
gnufied pushed a commit to gnufied/cluster-storage-operator that referenced this pull request Dec 4, 2019
The bracketed openshift/docs is from 881dbb7 (Add initial
enhancement templates, 2019-08-23, openshift#2).  But a link makes it easy for
folks to see where changes should go, and is something that can be
updated by enhancements to link specific PRs as they check off this
box.
openshift-merge-bot bot added a commit that referenced this pull request May 15, 2025
OCPBUGS-54491: sync Azure File permissions with upstream docs #2
openshift-merge-bot bot added a commit that referenced this pull request Jul 22, 2025
…78-to-release-4.19

[release-4.19] OCPBUGS-56253: sync Azure File permissions with upstream docs #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants