Skip to content

Conversation

@abhinavdahiya
Copy link
Contributor

@abhinavdahiya abhinavdahiya commented Dec 9, 2018

Please do not merge without green e2e-aws like here #2

An example is above where the crashlooping pod for this operator is preventing merges on other repos here:
https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/225/pull-ci-openshift-machine-config-operator-master-e2e-aws/618

failed: (5m2s) 2018-12-09T20:36:19 "[Feature:Platform][Smoke] Managed cluster should start all core operators [Suite:openshift/conformance/parallel] [Suite:openshift/smoke-4]"

because

sh-4.2$ oc -n openshift-cluster-storage-operator get all
NAME                                           READY     STATUS             RESTARTS   AGE
pod/cluster-storage-operator-6dd8c5774-v5std   0/1       CrashLoopBackOff   5          6m

NAME                                       DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/cluster-storage-operator   1         1         1            0           6m

NAME                                                 DESIRED   CURRENT   READY     AGE
replicaset.apps/cluster-storage-operator-6dd8c5774   1         1         0         6m
sh-4.2$ oc -n openshift-cluster-storage-operator logs cluster-storage-operator-6dd8c5774-v5std
2018/12/09 20:29:38 Go Version: go1.10.3
2018/12/09 20:29:38 Go OS/Arch: linux/amd64
2018/12/09 20:29:38 operator-sdk Version: v0.1.0+git
2018/12/09 20:29:38 Registering Components.
2018/12/09 20:29:38 Starting the Cmd.
2018/12/09 20:29:38 Reconciling ConfigMap kube-system/cluster-config-v1
E1209 20:29:38.905427       1 runtime.go:66] Observed a panic: "asset: Asset(manifests/aws.yaml): Asset manifests/aws.yaml not found" (asset: Asset(manifests/aws.yaml): Asset manifests/aws.yaml not found)
/go/src/github.com/openshift/cluster-storage-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:72
/go/src/github.com/openshift/cluster-storage-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:65
/go/src/github.com/openshift/cluster-storage-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:51
/usr/local/go/src/runtime/asm_amd64.s:573
/usr/local/go/src/runtime/panic.go:502
/go/src/github.com/openshift/cluster-storage-operator/pkg/generated/bindata.go:132
/go/src/github.com/openshift/cluster-storage-operator/pkg/controller/clusterstorage/clusterstorage_controller.go:163
/go/src/github.com/openshift/cluster-storage-operator/pkg/controller/clusterstorage/clusterstorage_controller.go:127
/go/src/github.com/openshift/cluster-storage-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:207
/go/src/github.com/openshift/cluster-storage-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:157
/go/src/github.com/openshift/cluster-storage-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133
/go/src/github.com/openshift/cluster-storage-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:134
/go/src/github.com/openshift/cluster-storage-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88
/usr/local/go/src/runtime/asm_amd64.s:2361
panic: asset: Asset(manifests/aws.yaml): Asset manifests/aws.yaml not found [recovered]
        panic: asset: Asset(manifests/aws.yaml): Asset manifests/aws.yaml not found

```console
sh-4.2$ oc -n openshift-cluster-storage-operator get all
NAME                                           READY     STATUS             RESTARTS   AGE
pod/cluster-storage-operator-6dd8c5774-v5std   0/1       CrashLoopBackOff   5          6m

NAME                                       DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/cluster-storage-operator   1         1         1            0           6m

NAME                                                 DESIRED   CURRENT   READY     AGE
replicaset.apps/cluster-storage-operator-6dd8c5774   1         1         0         6m
sh-4.2$ oc -n openshift-cluster-storage-operator logs cluster-storage-operator-6dd8c5774-v5std
2018/12/09 20:29:38 Go Version: go1.10.3
2018/12/09 20:29:38 Go OS/Arch: linux/amd64
2018/12/09 20:29:38 operator-sdk Version: v0.1.0+git
2018/12/09 20:29:38 Registering Components.
2018/12/09 20:29:38 Starting the Cmd.
2018/12/09 20:29:38 Reconciling ConfigMap kube-system/cluster-config-v1
E1209 20:29:38.905427       1 runtime.go:66] Observed a panic: "asset: Asset(manifests/aws.yaml): Asset manifests/aws.yaml not found" (asset: Asset(manifests/aws.yaml): Asset manifests/aws.yaml not found)
/go/src/github.com/openshift/cluster-storage-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:72
/go/src/github.com/openshift/cluster-storage-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:65
/go/src/github.com/openshift/cluster-storage-operator/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:51
/usr/local/go/src/runtime/asm_amd64.s:573
/usr/local/go/src/runtime/panic.go:502
/go/src/github.com/openshift/cluster-storage-operator/pkg/generated/bindata.go:132
/go/src/github.com/openshift/cluster-storage-operator/pkg/controller/clusterstorage/clusterstorage_controller.go:163
/go/src/github.com/openshift/cluster-storage-operator/pkg/controller/clusterstorage/clusterstorage_controller.go:127
/go/src/github.com/openshift/cluster-storage-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:207
/go/src/github.com/openshift/cluster-storage-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:157
/go/src/github.com/openshift/cluster-storage-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133
/go/src/github.com/openshift/cluster-storage-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:134
/go/src/github.com/openshift/cluster-storage-operator/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88
/usr/local/go/src/runtime/asm_amd64.s:2361
panic: asset: Asset(manifests/aws.yaml): Asset manifests/aws.yaml not found [recovered]
        panic: asset: Asset(manifests/aws.yaml): Asset manifests/aws.yaml not found
```

This repo is not gated by `e2e-aws` testing which means any changes merged in this repo can affect others. An example is above where the crashlooping pod for
this operator is preventing merges on other repos.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 9, 2018
@abhinavdahiya
Copy link
Contributor Author

/cc @smarterclayton @crawford

@crawford
Copy link

crawford commented Dec 9, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2018
@wking
Copy link
Member

wking commented Dec 9, 2018

/lgtm

@wking
Copy link
Member

wking commented Dec 9, 2018

@jsafrane, @childsb, @tsmetana, @gnufied, @wongma7, @bertinatto, can we get maintainer approval on this to unblock org-wide CI?

@childsb
Copy link

childsb commented Dec 9, 2018

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, childsb, crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2018
@childsb
Copy link

childsb commented Dec 9, 2018

/test e2e-aws

@crawford
Copy link

Need to force this through in order to fix CI.

/override ci/prow/e2e-aws

@wking
Copy link
Member

wking commented Dec 10, 2018

/retest

@crawford
Copy link

I don't have admin on this repo, so my override doesn't work (I figured the bot would yell at me).

@childsb are you able to merge this directly (or do the override)?

@wking
Copy link
Member

wking commented Dec 10, 2018

/retest

@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 34563f3 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton smarterclayton merged commit 2b29678 into openshift:master Dec 10, 2018
gnufied pushed a commit to gnufied/cluster-storage-operator that referenced this pull request Dec 4, 2019
Windows Containers productization design
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants