Skip to content

Bug 2034484: library-go bump#232

Merged
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
eggfoobar:library_go_bump
Jan 4, 2022
Merged

Bug 2034484: library-go bump#232
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
eggfoobar:library_go_bump

Conversation

@eggfoobar
Copy link
Copy Markdown
Contributor

@eggfoobar eggfoobar commented Dec 10, 2021 •
edited
Loading

Bumping the library-go dependency to latest, this should take advantage of leader election changes for SNO clusters proposed in this library-go PR and performance improvements in this PR.

Changes:

  • updated library-go to latest
  • updated build images to go 1.17

Signed-off-by: ehila ehila@redhat.com

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2021
@openshift-ci openshift-ci Bot requested review from gabemontero and sttts December 10, 2021 18:56
@eggfoobar
feat: library-go bump
f837d44 
updated library-go to latest
updated build images to use go 1.17

Signed-off-by: ehila <ehila@redhat.com>

feat: explicit call to bind logs cli flags

Signed-off-by: ehila <ehila@redhat.com>
@eggfoobar eggfoobar changed the title [WIP] feat: library-go bump feat: library-go bump Dec 15, 2021
@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 15, 2021
@eggfoobar
upkeep: updated to use cli component for cleaner code
10f4668 
Signed-off-by: ehila <ehila@redhat.com>
@eggfoobar
Copy link
Copy Markdown
Contributor Author

eggfoobar commented Dec 16, 2021

/assign @mfojtik

@eggfoobar
fix: pull in latest library-go
06c2b14 
pull in to grab fix described here openshift/library-go#1272

Signed-off-by: ehila <ehila@redhat.com>
@jerpeter1
Copy link
Copy Markdown
Member

jerpeter1 commented Dec 17, 2021

/retest-required

@jerpeter1 jerpeter1 removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2021
@eggfoobar
bump: library-go
34e157c 
updated library-go to latest for fix in pr openshift/library-go#1273

Signed-off-by: ehila <ehila@redhat.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 20, 2021

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@eggfoobar
Copy link
Copy Markdown
Contributor Author

eggfoobar commented Dec 21, 2021

/retitle Bug 2034484: feat: library-go bump
This PR bumps to latest library-go to utilize changes for performance gains on SNO DU clusters

@openshift-ci openshift-ci Bot changed the title feat: library-go bump Bug 2034484: feat: library-go bump Dec 21, 2021
@openshift-ci openshift-ci Bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 21, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 21, 2021

@eggfoobar: This pull request references Bugzilla bug 2034484, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (jhou@redhat.com), skipping review request.

Details

In response to this:

Bug 2034484: feat: library-go bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund
Copy link
Copy Markdown
Member

ingvagabund commented Jan 4, 2022

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2022
@openshift-merge-robot openshift-merge-robot merged commit efd1aeb into openshift:master Jan 4, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 4, 2022

@eggfoobar: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2034484 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 2034484: feat: library-go bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund ingvagabund mentioned this pull request Jan 4, 2022
Closed
@jerpeter1 jerpeter1 changed the title Bug 2034484: feat: library-go bump Bug 2034484: library-go bump Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabemontero gabemontero Awaiting requested review from gabemontero

@sttts sttts Awaiting requested review from sttts

Assignees

@mfojtik mfojtik

@ingvagabund ingvagabund

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eggfoobar @jerpeter1 @ingvagabund @mfojtik @openshift-merge-robot