Bug 2034484: feat: library-go bump#488
Bug 2034484: feat: library-go bump#488openshift-merge-robot merged 5 commits intoopenshift:masterfrom
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
eggfoobar
force-pushed
the
library_go_bump
branch
2 times, most recently
from
a923499 to
fdeff7b
Compare
updated library-go to latest updated build-machinery-go to fix yaml_patch make command updated builder images and go.mod to go 1.17 Signed-off-by: ehila <ehila@redhat.com> fix: logs now needs to be explicitly bound to flags Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
force-pushed
the
library_go_bump
branch
from
fdeff7b to
ee0dcc6
Compare
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: ehila <ehila@redhat.com>
pull in to grab fix described here openshift/library-go#1272 Signed-off-by: ehila <ehila@redhat.com>
latest library-go update allows for finer control of static resource controller, altered call sight to match new method signature Signed-off-by: ehila <ehila@redhat.com>
|
/assign @tkashem |
updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
|
/retitle Bug 2034484: feat: library-go bump /retest-required |
openshift-ci
Bot
changed the title
openshift-ci
Bot
added
bugzilla/severity-high
|
@eggfoobar: This pull request references Bugzilla bug 2034484, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (jhou@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@eggfoobar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
openshift-ci
Bot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, eggfoobar, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@eggfoobar: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2034484 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
Bumping the library-go dependency to latest, this should take advantage of leader election changes for SNO clusters proposed in this library-go PR and performance improvements in this PR.
Changes:
Signed-off-by: ehila ehila@redhat.com