Backporting Tuned rendering and MCP detection improvements

[rbaturov]

• NTO: Add MCP name to filter PP (CNF-10587: NTO: Fine tuning render bootcmd mc command #878)

render-bootcmd-mc can only compute the kernel args for a MachineConfigPool that matches the node it is executed on, so we add the MachineConfigPool name as input parameter to filter the applicable PerformanceProfiles.

• OCPBUGS-22095: Add default MCP objects for rendering (OCPBUGS-22095: Add default MCP objects for rendering #833)

• feat: update render command to create default MCPs

added default MCP creation to help correctly render out the resources for performance profile to use

upkeep: fix spelling

• feat: add default mcpools to tuned renderer

---

• Enhance render sync to include bootstrap rendering tests

• Render MC without additional PP

This command should render a MC from the available sources. PerformanceProfile is a source, but it is not mandatory.

So, as there are scenarios where this command should work with no additional PP let's the command proceed even if there is no PP

• Render sync

---

[openshift-ci-robot]

@rbaturov: This pull request references Jira Issue OCPBUGS-27948, which is invalid:

• expected the bug to target either version "4.14." or "openshift-4.14.", but it targets "4.15.0" instead
• expected dependent Jira Issue OCPBUGS-22095 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
• expected dependent Jira Issue OCPBUGS-22095 to target a version in 4.15.0, 4.15.z, but it targets "4.16.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

• NTO: Add MCP name to filter PP (CNF-10587: NTO: Fine tuning render bootcmd mc command #878)

render-bootcmd-mc can only compute the kernel args for a MachineConfigPool that matches the node it is executed on, so we add the MachineConfigPool name as input parameter to filter the applicable PerformanceProfiles.

• OCPBUGS-22095: Add default MCP objects for rendering (OCPBUGS-22095: Add default MCP objects for rendering #833)

• feat: update render command to create default MCPs

added default MCP creation to help correctly render out the resources for performance profile to use

upkeep: fix spelling

• feat: add default mcpools to tuned renderer

---

• Enhance render sync to include bootstrap rendering tests

• Render MC without additional PP

This command should render a MC from the available sources. PerformanceProfile is a source, but it is not mandatory.

So, as there are scenarios where this command should work with no additional PP let's the command proceed even if there is no PP

• Render sync

---

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@rbaturov: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

• NTO: Add MCP name to filter PP (CNF-10587: NTO: Fine tuning render bootcmd mc command #878)

render-bootcmd-mc can only compute the kernel args for a MachineConfigPool that matches the node it is executed on, so we add the MachineConfigPool name as input parameter to filter the applicable PerformanceProfiles.

• OCPBUGS-22095: Add default MCP objects for rendering (OCPBUGS-22095: Add default MCP objects for rendering #833)

• feat: update render command to create default MCPs

added default MCP creation to help correctly render out the resources for performance profile to use

upkeep: fix spelling

• feat: add default mcpools to tuned renderer

---

• Enhance render sync to include bootstrap rendering tests

• Render MC without additional PP

This command should render a MC from the available sources. PerformanceProfile is a source, but it is not mandatory.

So, as there are scenarios where this command should work with no additional PP let's the command proceed even if there is no PP

• Render sync

---

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rbaturov
Once this PR has been reviewed and has the lgtm label, please assign jmencak for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yanirq]

@rbaturov please add bug title once https://issues.redhat.com/browse/OCPBUGS-27948 is cloned for 4.14

[yanirq]

/retest

[openshift-ci]

@rbaturov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn	5ee029e	link	true	/test e2e-aws-ovn
ci/prow/e2e-no-cluster	5ee029e	link	true	/test e2e-no-cluster
ci/prow/e2e-gcp-pao	5ee029e	link	true	/test e2e-gcp-pao
ci/prow/images	5ee029e	link	true	/test images
ci/prow/unit	5ee029e	link	true	/test unit
ci/prow/e2e-hypershift	5ee029e	link	true	/test e2e-hypershift
ci/prow/e2e-gcp-pao-updating-profile	5ee029e	link	true	/test e2e-gcp-pao-updating-profile
ci/prow/e2e-upgrade	5ee029e	link	true	/test e2e-upgrade
ci/prow/e2e-gcp-pao-workloadhints	5ee029e	link	true	/test e2e-gcp-pao-workloadhints
ci/prow/vet	5ee029e	link	true	/test vet
ci/prow/e2e-aws-operator	5ee029e	link	true	/test e2e-aws-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[rbaturov]

/hold
Further backports need to be done like
901f395
to continue.

[openshift-merge-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yanirq]

@rbaturov is this PR still needed ?

[rbaturov]

@rbaturov is this PR still needed ?

Yes, it's required to backport #954.

[yanirq]

@rbaturov is this PR still needed ?

Yes, it's required to backport #954.

Did you mean #928 ? (954 is not directly related)

[rbaturov]

@rbaturov is this PR still needed ?

Yes, it's required to backport #954.

Did you mean #928 ? (954 is not directly related)

I meant that it will be needed to backport #954 in the future, which is indirectly related (but depends on this).