Skip to content

ovn: container env variables need quotes#440

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
dcbw:quote-env-vars
Jan 8, 2020
Merged

ovn: container env variables need quotes#440
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
dcbw:quote-env-vars

Conversation

@dcbw
Copy link
Contributor

@dcbw dcbw commented Jan 8, 2020

@danwinship

Otherwise:
2020/01/08 03:54:48 could not apply (apps/v1, Kind=DaemonSet) openshift-ovn-kubernetes/ovnkube-master: could not create (apps/v1, Kind=DaemonSet) openshift-ovn-kubernetes/ovnkube-master: DaemonSet in version "v1" cannot be handled as a DaemonSet: v1.DaemonSet.Spec: v1.DaemonSetSpec.Template: v1.PodTemplateSpec.Spec: v1.PodSpec.Containers: []v1.Container: v1.Container.Env: []v1.EnvVar: v1.EnvVar.v1.EnvVar.Value: ReadString: expects " or n, but found 4, error found in #10 byte of ...|,"value":4},{"name":|..., bigger context ...|\n"],"env":[{"name":"OVN_KUBE_LOG_LEVEL","value":4},{"name":"K8S_NODE","valueFrom":{"fieldRef":{"fie|...

Fixes: a520900

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 8, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2020
@dcbw
Copy link
Contributor Author

dcbw commented Jan 8, 2020

/test e2e-aws-ovn

Otherwise:
2020/01/08 03:54:48 could not apply (apps/v1, Kind=DaemonSet) openshift-ovn-kubernetes/ovnkube-master: could not create (apps/v1, Kind=DaemonSet) openshift-ovn-kubernetes/ovnkube-master: DaemonSet in version "v1" cannot be handled as a DaemonSet: v1.DaemonSet.Spec: v1.DaemonSetSpec.Template: v1.PodTemplateSpec.Spec: v1.PodSpec.Containers: []v1.Container: v1.Container.Env: []v1.EnvVar: v1.EnvVar.v1.EnvVar.Value: ReadString: expects " or n, but found 4, error found in openshift#10 byte of ...|,"value":4},{"name":|..., bigger context ...|\n"],"env":[{"name":"OVN_KUBE_LOG_LEVEL","value":4},{"name":"K8S_NODE","valueFrom":{"fieldRef":{"fie|...

Fixes: a520900
@dcbw
Copy link
Contributor Author

dcbw commented Jan 8, 2020

/test e2e-aws-ovn

@dcbw
Copy link
Contributor Author

dcbw commented Jan 8, 2020

/test e2e-aws-ovn

@alexanderConstantinescu
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderConstantinescu, dcbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexanderConstantinescu
Copy link
Contributor

/test e2e-aws-ovn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments