hack: disable verify-codegen in verify-style#10
Merged
squeed merged 1 commit intoopenshift:masterfrom Sep 26, 2018
squeed:build-fixes
Merged
hack: disable verify-codegen in verify-style#10squeed merged 1 commit intoopenshift:masterfrom squeed:build-fixes
squeed merged 1 commit intoopenshift:masterfrom
squeed:build-fixes
Conversation
It doesn't work on openshift-ci, for some reason, and isn't really that important.
trozet
referenced
this pull request
Jan 7, 2020
The way to change this is via the env-overrides configmap, so we don't need to make the value settable via the template.
dcbw
added a commit
to dcbw/cluster-network-operator
that referenced
this pull request
Jan 8, 2020
Otherwise: 2020/01/08 03:54:48 could not apply (apps/v1, Kind=DaemonSet) openshift-ovn-kubernetes/ovnkube-master: could not create (apps/v1, Kind=DaemonSet) openshift-ovn-kubernetes/ovnkube-master: DaemonSet in version "v1" cannot be handled as a DaemonSet: v1.DaemonSet.Spec: v1.DaemonSetSpec.Template: v1.PodTemplateSpec.Spec: v1.PodSpec.Containers: []v1.Container: v1.Container.Env: []v1.EnvVar: v1.EnvVar.v1.EnvVar.Value: ReadString: expects " or n, but found 4, error found in openshift#10 byte of ...|,"value":4},{"name":|..., bigger context ...|\n"],"env":[{"name":"OVN_KUBE_LOG_LEVEL","value":4},{"name":"K8S_NODE","valueFrom":{"fieldRef":{"fie|... Fixes: a520900
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It doesn't work on openshift-ci, for some reason, and isn't really
that important.