Remove some unwanted logging. Fix an error message#437
Remove some unwanted logging. Fix an error message#437openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
danwinship
force-pushed
the
cleanup-333
branch
from
21a5c01 to
4bda7b7
Compare
|
/retest |
|
@pecameron You seemed to have hard-coded the ovnkube-master/node log-level to 4, independently of what might be specified in any configfile/configmap. See L75 in @danwinship : could you change that in this PR? I am only asking as to have one atomic change taking care of all of those issues. |
|
That's not really a change. Previously the daemonset specified now it specifies and templates in the so... I guess there's not really any reason to be templating the default value in... |
The way to change this is via the env-overrides configmap, so we don't need to make the value settable via the template.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderConstantinescu, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
7 participants
#333 added logging of the ovn-kube TLS keys to the startup of all of the daemons. I assume @pecameron did this for debugging reasons at one point and then forgot to remove it? If the admin wants to see the key they can just look at the Secret directly... we should not be logging private keys to pod logs.
I'm assuming that for the other fix here (removing "PHIL" from an error message) we actually do want to keep that check.