OVN: use config file via ConfigMap rather than environment variables by pecameron · Pull Request #333 · openshift/cluster-network-operator

pecameron · 2019-10-04T14:02:20Z

Configure ovnkube using a config file passed by the ovnkube-config
configMap and mountedinto the container.

SDN-456
https://jira.coreos.com/browse/SDN-456

Signed-off-by: Phil Cameron pcameron@redhat.com

bindata/network/ovn-kubernetes/004-config.yaml

danwinship · 2019-10-05T19:23:45Z

You should squash #335 into this

bindata/network/ovn-kubernetes/004-config.yaml

squeed · 2019-10-07T12:13:05Z

This is a better way to do things, for sure. However, we need to add something to ovnkube that causes it to exit on configuration changes.

danwinship · 2019-10-07T14:59:30Z

You should squash #335 into this

oops, too late. needs-rebase now

bindata/network/ovn-kubernetes/ovnkube-node.yaml

pecameron · 2019-10-07T19:00:27Z

/test e2e-aws-ovn-kubernetes

pecameron · 2019-10-08T13:45:01Z

/test e2e-aws-ovn-kubernetes

bindata/network/ovn-kubernetes/ovnkube-master.yaml

squeed · 2019-10-08T15:33:58Z

Two small changes, otherwise looks fine.

pecameron · 2019-10-08T20:30:17Z

@squeed PTAL

pecameron · 2019-10-08T22:52:41Z

/test e2e-aws
/test e2e-aws-ovn-kubernetes

squeed · 2019-10-09T12:42:41Z

Those test failures are not the expected set of failures for ovn-kube. Something is wrong. You'll have to dig in a bit further.

pecameron · 2019-10-10T17:31:27Z

/test e2e-aws-ovn-kubernetes

pecameron · 2019-10-10T20:05:26Z

@squeed didn't spot anything (still not sure what to look for or where) so I ran the test again.

squeed · 2019-10-11T11:50:18Z

Huh... something is weird with the ingress operator:

"message": "pods \"ingress-operator-695f4b555-\" is forbidden: no SecurityContextConstraints found in cluster",

I don't think this is an ovn problem.

/test e2e-aws-ovn-kubernetes

pecameron · 2019-12-10T12:24:58Z

/test e2e-aws-ovn

pecameron · 2019-12-10T17:04:04Z

/test e2e-aws-ovn

dcbw · 2019-12-13T16:05:23Z

/test e2e-aws-ovn

pecameron · 2019-12-16T14:18:56Z

/retest

pecameron · 2019-12-16T14:19:18Z

/test e2e-aws-ovn

squeed · 2019-12-16T14:49:11Z

It does seem like the MTU is problematic. Can you check to see if the MTU is correctly respected by all of the interfaces? Perhaps the gateway code hard-codes it when it shouldn't.

squeed · 2019-12-16T14:50:02Z

Yes, scanning the gateway code shows that it doesn't seem to consume mtu @dcbw

pecameron · 2019-12-16T15:27:14Z

@squeed, @dcbw, whatever is happening here is not happening in other PRs. The mtu is generally handled properly. This might be a corner case. In the spirit of race conditions as we have seen in not getting the correct number of masters, is it possible that the sll certs are not set by the time they are used? The problem discussed in the f2f was in host networking ssl between ovs/ovn components.

squeed · 2019-12-16T15:34:11Z

My evidence for this is that the control plane seems to come up fine, but the openshift-apiserver (a non-hostnetwork component) times out when trying to write a response back to the kube-apsierver (which is hostnetwork).

Looking at the gateway code, I see that the interface created does not have the MTU passed.

Get what I'm saying? Would you mind checking to see if I'm right? If not, can you please spin up a cluster for me and I can check?

pecameron · 2019-12-16T16:52:34Z

@squeed Yes I get what you are saying. Why does that happen in PR 333 and not happen in other PRs? What you are asserting should have wide spread impact.

The analysis from the f2f showed an ssl problem accessing sdb:9642 using host networking. The connection was established and ssl failed.

I am spinning up a cluster, I'll let you know when it is ready.

pecameron · 2019-12-16T18:02:13Z

@squeed cluster didn't come up, bad token. Trying again.

Configure ovnkube using a config file passed by the ovnkube-config configMap and mounted into the container. SDN-498 Allow overriding MTU in ovn-kubernetes https://jira.coreos.com/browse/SDN-498 The mtu is passed in the configmap. bug 1779105 https://bugzilla.redhat.com/show_bug.cgi?id=1779105 SDN-456 OVN: use config file via ConfigMap rather than environment variables https://jira.coreos.com/browse/SDN-456 Signed-off-by: Phil Cameron <pcameron@redhat.com>

pecameron · 2019-12-16T18:29:12Z

/test e2e-aws-ovn

pecameron · 2019-12-16T18:44:54Z

/retest
/test e2e-aws-ovn

dcbw · 2019-12-29T15:45:33Z

/test e2e-aws-ovn
/test e2e-gcp

openshift-ci-robot · 2019-12-29T17:04:47Z

@pecameron: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-ovn-kubernetes	`247f1ad`	link	`/test e2e-aws-ovn-kubernetes`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dcbw · 2019-12-29T17:48:00Z

/test e2e-gcp

dcbw · 2019-12-29T22:44:14Z

/lgtm

dcbw · 2019-12-29T22:44:20Z

/approve

openshift-ci-robot · 2019-12-29T22:44:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, pecameron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dcbw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 4, 2019

openshift-ci-robot requested review from JacobTanenbaum and dcbw October 4, 2019 14:02

pecameron mentioned this pull request Oct 4, 2019

OVN: use config file via ConfigMap rather than environment variables #217

Closed

danwinship reviewed Oct 4, 2019

View reviewed changes

bindata/network/ovn-kubernetes/004-config.yaml Outdated Show resolved Hide resolved

pecameron force-pushed the sdn456a branch from 9e7c609 to 47ff2f8 Compare October 4, 2019 19:39

danwinship mentioned this pull request Oct 5, 2019

ovn-kubernetes: fix endpoint namespace #335

Merged

squeed reviewed Oct 7, 2019

View reviewed changes

bindata/network/ovn-kubernetes/004-config.yaml Outdated Show resolved Hide resolved

squeed reviewed Oct 7, 2019

View reviewed changes

bindata/network/ovn-kubernetes/004-config.yaml Outdated Show resolved Hide resolved

pecameron force-pushed the sdn456a branch from 47ff2f8 to b6f9d0f Compare October 7, 2019 15:49

squeed reviewed Oct 7, 2019

View reviewed changes

bindata/network/ovn-kubernetes/ovnkube-node.yaml Outdated Show resolved Hide resolved

pecameron force-pushed the sdn456a branch from b6f9d0f to cbc1608 Compare October 7, 2019 17:00

pecameron force-pushed the sdn456a branch from cbc1608 to 49f1b45 Compare October 8, 2019 13:44

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 8, 2019

squeed reviewed Oct 8, 2019

View reviewed changes

bindata/network/ovn-kubernetes/ovnkube-master.yaml Outdated Show resolved Hide resolved

pecameron force-pushed the sdn456a branch from 49f1b45 to 4599908 Compare October 8, 2019 20:29

pecameron force-pushed the sdn456a branch from 4599908 to 9cbc501 Compare October 9, 2019 20:28

pecameron force-pushed the sdn456a branch from 9e450d2 to eb3b64d Compare December 16, 2019 18:12

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 16, 2019

openshift-ci-robot assigned dcbw Dec 29, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 29, 2019

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2019

openshift-merge-robot merged commit 1d08233 into openshift:master Dec 30, 2019

pecameron deleted the sdn456a branch January 2, 2020 15:25

danwinship mentioned this pull request Jan 6, 2020

Remove some unwanted logging. Fix an error message #437

Merged

danwinship mentioned this pull request Feb 18, 2020

Bug 1806009: Backport ovn-kubernetes-related changes to 4.3 #483

Merged

Conversation

pecameron commented Oct 4, 2019

Uh oh!

Uh oh!

danwinship commented Oct 5, 2019

Uh oh!

Uh oh!

Uh oh!

squeed commented Oct 7, 2019

Uh oh!

danwinship commented Oct 7, 2019

Uh oh!

Uh oh!

pecameron commented Oct 7, 2019

Uh oh!

pecameron commented Oct 8, 2019

Uh oh!

Uh oh!

squeed commented Oct 8, 2019

Uh oh!

pecameron commented Oct 8, 2019

Uh oh!

pecameron commented Oct 8, 2019

Uh oh!

squeed commented Oct 9, 2019

Uh oh!

pecameron commented Oct 10, 2019

Uh oh!

pecameron commented Oct 10, 2019

Uh oh!

squeed commented Oct 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pecameron commented Dec 10, 2019

Uh oh!

pecameron commented Dec 10, 2019

Uh oh!

dcbw commented Dec 13, 2019

Uh oh!

pecameron commented Dec 16, 2019

Uh oh!

pecameron commented Dec 16, 2019

Uh oh!

squeed commented Dec 16, 2019

Uh oh!

squeed commented Dec 16, 2019

Uh oh!

pecameron commented Dec 16, 2019

Uh oh!

squeed commented Dec 16, 2019

Uh oh!

pecameron commented Dec 16, 2019

Uh oh!

pecameron commented Dec 16, 2019

Uh oh!

pecameron commented Dec 16, 2019

Uh oh!

pecameron commented Dec 16, 2019

Uh oh!

dcbw commented Dec 29, 2019

Uh oh!

openshift-ci-robot commented Dec 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dcbw commented Dec 29, 2019

Uh oh!

dcbw commented Dec 29, 2019

Uh oh!

dcbw commented Dec 29, 2019

Uh oh!

openshift-ci-robot commented Dec 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

squeed commented Oct 11, 2019 •

edited

Loading

openshift-ci-robot commented Dec 29, 2019 •

edited

Loading