ovn-kubernetes: fix endpoint namespace#335
ovn-kubernetes: fix endpoint namespace#335openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
Upstream defaults to just 'ovn-kubernetes' but we need to use openshift-ovn-kubernetes. Fixes: 0ac2cdf
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw, JacobTanenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
| --cluster-subnets "${OVN_NET_CIDR}" \ | ||
| --k8s-service-cidr "${OVN_SVC_CIDR}" \ | ||
| --k8s-apiserver "{{.K8S_APISERVER}}" \ | ||
| --ovn-config-namespace openshift-ovn-kubernetes \ |
There was a problem hiding this comment.
--ovn-config-namespace is only relevant if we're using a configmap, which we aren't yet. It seems like this part belongs in #333 and all you need here is the kubectl fix
There was a problem hiding this comment.
@danwinship it will be used for the master creating endpoints in ovn-kubernetes/ovn-kubernetes#763 at some point here too
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 participants
Upstream defaults to just 'ovn-kubernetes' but we need to use
openshift-ovn-kubernetes.
Fixes: 0ac2cdf
@squeed @JacobTanenbaum @danwinship