[WIP][DNM] ic install and upgrade -> OLD#1838
Closed
ricky-rav wants to merge 6 commits intoopenshift:masterfrom
Closed
[WIP][DNM] ic install and upgrade -> OLD#1838ricky-rav wants to merge 6 commits intoopenshift:masterfrom
ricky-rav wants to merge 6 commits intoopenshift:masterfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
ricky-rav
force-pushed
the
ICinstall
branch
4 times, most recently
from
ca1b3e4 to
4f821f7
Compare
ricky-rav
force-pushed
the
ICinstall
branch
5 times, most recently
from
74f7c30 to
c474fd1
Compare
openshift-merge-robot
added
needs-rebase
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ricky-rav The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 similar comment
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ricky-rav The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ricky-rav
force-pushed
the
ICinstall
branch
3 times, most recently
from
53ec5d5 to
05ba374
Compare
ricky-rav
force-pushed
the
ICinstall
branch
3 times, most recently
from
838e77b to
cf2aaa2
Compare
Contributor
|
/retest-required |
ricky-rav
force-pushed
the
ICinstall
branch
2 times, most recently
from
262bc4e to
685070f
Compare
Contributor
|
/retest |
Contributor
|
/retest |
ricky-rav
force-pushed
the
ICinstall
branch
3 times, most recently
from
d062a1a to
e7d0a85
Compare
This was referenced Jul 10, 2023
ricky-rav
force-pushed
the
ICinstall
branch
2 times, most recently
from
da9ee61 to
e1ce2f2
Compare
ricky-rav
changed the title
- Determine OVN interconnect zone mode by inspecting an (optional) configMap; apply the desired zone mode. - upgrade from non-IC to IC OVN-K by going through an intermediate step with 1-zone - Switch from IC single zone to IC multizone (as in upgrades) and back (not fully supported yet, for internal use only) Avoid clashes between single-zone ovnkube-master (using ports 9102, 9641, 9642, 29102) and multizone ovnkube-node (initially using ports 9103, 9105, 9102, 29102, 29103) during upgrade from 4.13 and avoid using ports reserved for the storage components, as described in https://github.com/openshift/enhancements/blob/master/dev-guide/host-port-registry.md This caused the storage operator to never be available after installation of or upgrade to 4.14. In multizone ovnkube-node let's now have: - 9103, 9105, 29103 (which don't collide with single-zone ovnkube-master) - 9112, 9112 9113, 29113 so as to not collide with single-zone ovnkube-master Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
In the very last step of the 2-phase upgrade to OVN interconnect, we remove the IC configmap. At this point, SetFromPods from pod_status.go won't be called any more, because all changes to the daemonsets have been processed. Patch the ovnk master daemonset with a dummy annotation to trigger status recalculation. TODO: find a better way to run SetFromPods instead of updating ovnk master annotations Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
Signed-off-by: Flavio Fernandes <flaviof@redhat.com>
openshift-merge-robot
added
the
needs-rebase
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
|
@ricky-rav: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old code for IC in standalone openshift only. Doesn't work with hypershift.
-> Current reference for IC support in CNO is #1874.