Closed
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bpickard22 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
bpickard22
force-pushed
the
ic-alert-refactor
branch
from
bde2828 to
0989e92
Compare
Contributor
|
@bpickard22 : please rebase this on top of #1838 (meaning include Ric's commits and then yours as well - otherwise we won't be able to see the CI on the actual thing before you hand it to Ric and he will have to fix stuff) : I'd like to see a green CI on Interconnect, as far as alerts are concerned. |
bpickard22
force-pushed
the
ic-alert-refactor
branch
from
0989e92 to
911d7fe
Compare
openshift-merge-robot
added
the
needs-rebase
- Determine OVN interconnect zone mode by inspecting an (optional) configMap; apply the desired zone mode. - upgrade from non-IC to IC OVN-K by going through an intermediate step with 1-zone - Switch from IC single zone to IC multizone (as in upgrades) and back (not fully supported yet, for internal use only) Avoid clashes between single-zone ovnkube-master (using ports 9102, 9641, 9642, 29102) and multizone ovnkube-node (initially using ports 9103, 9105, 9102, 29102, 29103) during upgrade from 4.13 and avoid using ports reserved for the storage components, as described in https://github.com/openshift/enhancements/blob/master/dev-guide/host-port-registry.md This caused the storage operator to never be available after installation of or upgrade to 4.14. In multizone ovnkube-node let's now have: - 9103, 9105, 29103 (which don't collide with single-zone ovnkube-master) - 9112, 9112 9113, 29113 so as to not collide with single-zone ovnkube-master Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
In the very last step of the 2-phase upgrade to OVN interconnect, we remove the IC configmap. At this point, SetFromPods from pod_status.go won't be called any more, because all changes to the daemonsets have been processed. Patch the ovnk master daemonset with a dummy annotation to trigger status recalculation. TODO: find a better way to run SetFromPods instead of updating ovnk master annotations Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
Beware: this goes with https://github.com/openshift/ovn-kubernetes/pull/1727/commits Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
In ovn-ic there will be no raft as each node will have its own instance of the databases, so we can remove the raft related alerts Signed-off-by: Ben Pickard <bpickard@redhat.com>
Refactor alerts to run based off new metric names in ovn-ic Signed-off-by: Ben Pickard <bpickard@redhat.com>
bpickard22
force-pushed
the
ic-alert-refactor
branch
from
911d7fe to
4289b01
Compare
openshift-merge-robot
removed
the
needs-rebase
Contributor
|
@bpickard22: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-robot
added
the
needs-rebase
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to allow for review only, this commit will be given to @ricky-rav as part of his work in CNO for ovn-ic
@ricky-rav i need some eyes on the labels for the service monitor to make sure I am using the right syntax
Also need someone from the monitoring team to take a look at the alert expressions to make sure I am going about that correctly