Skip to content

[WIP][DNM] IC install (debugging PR)#1862

Closed
ricky-rav wants to merge 5 commits intoopenshift:masterfrom
ricky-rav:ICinstallWIP
Closed

[WIP][DNM] IC install (debugging PR)#1862
ricky-rav wants to merge 5 commits intoopenshift:masterfrom
ricky-rav:ICinstallWIP

Conversation

@ricky-rav
Copy link
Contributor

@ricky-rav ricky-rav commented Jul 4, 2023

Keeping #1838 as reference, debugging on this PR

Remove 685070f to let CI run

ricky-rav added 5 commits July 3, 2023 14:55
- Determine OVN interconnect zone mode by inspecting an (optional) configMap; apply the desired zone mode.
- upgrade from non-IC to IC OVN-K by going through an intermediate step with 1-zone
- Switch from IC single zone to IC multizone (as in upgrades) and back (not fully supported yet, for internal use only)

Avoid clashes between single-zone ovnkube-master (using ports 9102, 9641, 9642, 29102) and multizone ovnkube-node (initially using ports 9103, 9105, 9102, 29102, 29103) during upgrade from 4.13 and avoid using ports reserved for the storage components, as described in https://github.com/openshift/enhancements/blob/master/dev-guide/host-port-registry.md  This caused the storage operator to never be available after installation of or upgrade to 4.14.

In multizone ovnkube-node let's now have:
- 9103, 9105, 29103 (which don't collide with single-zone ovnkube-master)
- 9112, 9112 9113, 29113 so as to not collide with single-zone ovnkube-master

Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
In the very last step of the 2-phase upgrade to OVN interconnect, we remove the IC configmap.
At this point, SetFromPods from pod_status.go won't be called any more, because all changes to the daemonsets have been processed. Patch the ovnk master daemonset with a dummy annotation to trigger status recalculation.

TODO: find a better way to run SetFromPods instead of updating ovnk master annotations

Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2023
@ricky-rav ricky-rav changed the title [WIP[DNM] IC install (debugging PR) [WIP][DNM] IC install (debugging PR) Jul 4, 2023
@openshift-ci openshift-ci bot requested review from danwinship and dougbtv July 4, 2023 07:11
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 4, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ricky-rav
Once this PR has been reviewed and has the lgtm label, please assign dougbtv for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ricky-rav
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 4, 2023

@ricky-rav: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn 9a237f2 link false /test e2e-vsphere-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec 9a237f2 link false /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-gcp-ovn 9a237f2 link true /test e2e-gcp-ovn
ci/prow/e2e-network-mtu-migration-ovn-ipv6 9a237f2 link false /test e2e-network-mtu-migration-ovn-ipv6
ci/prow/e2e-aws-ovn-network-migration 9a237f2 link true /test e2e-aws-ovn-network-migration
ci/prow/e2e-ovn-hybrid-step-registry 9a237f2 link false /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-aws-ovn-serial 9a237f2 link false /test e2e-aws-ovn-serial
ci/prow/e2e-ovn-step-registry 9a237f2 link false /test e2e-ovn-step-registry
ci/prow/e2e-metal-ipi-ovn-ipv6 9a237f2 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-azure-ovn 9a237f2 link false /test e2e-azure-ovn
ci/prow/e2e-gcp-ovn-upgrade 9a237f2 link false /test e2e-gcp-ovn-upgrade
ci/prow/e2e-vsphere-ovn-windows 9a237f2 link true /test e2e-vsphere-ovn-windows
ci/prow/e2e-network-mtu-migration-ovn-ipv4 9a237f2 link false /test e2e-network-mtu-migration-ovn-ipv4
ci/prow/e2e-openstack-ovn 9a237f2 link false /test e2e-openstack-ovn
ci/prow/e2e-gcp-sdn 9a237f2 link true /test e2e-gcp-sdn
ci/prow/e2e-aws-ovn-single-node 9a237f2 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-ovn-ipsec-step-registry 9a237f2 link false /test e2e-ovn-ipsec-step-registry
ci/prow/e2e-vsphere-ovn-dualstack 9a237f2 link false /test e2e-vsphere-ovn-dualstack
ci/prow/unit 9a237f2 link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ricky-rav ricky-rav closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants