Skip to content

Bug 1953798: Remove the upstream KubeAPIErrorBudgetBurn alerts#1164

Merged
openshift-merge-robot merged 2 commits into
openshift:masterfrom
ihcsim:exclude-kube-apiserver-slos-rules
May 25, 2021
Merged

Bug 1953798: Remove the upstream KubeAPIErrorBudgetBurn alerts#1164
openshift-merge-robot merged 2 commits into
openshift:masterfrom
ihcsim:exclude-kube-apiserver-slos-rules

Conversation

@ihcsim

@ihcsim ihcsim commented May 17, 2021

Copy link
Copy Markdown

This PR removes the upstream KubeAPIErrorBudgetBurn alerts and their
recording rules. These rules have been moved to the
openshift/cluster-kube-apiserver-operator repository. See
openshift/cluster-kube-apiserver-operator#1126.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

These alerts and their recording rules have been moved to the
cluster-kube-apiserver-operator repository. See
openshift/cluster-kube-apiserver-operator#1126

Signed-off-by: Ivan Sim <isim@redhat.com>
@openshift-ci openshift-ci Bot requested review from bison and s-urbaniak May 17, 2021 20:43
@ihcsim

ihcsim commented May 17, 2021

Copy link
Copy Markdown
Author

@openshift/openshift-team-monitoring PTAL. Thanks!

cc @s-urbaniak

@s-urbaniak

Copy link
Copy Markdown
Contributor

lgtm from my side 👍
/approve

@s-urbaniak

Copy link
Copy Markdown
Contributor

leaving final pair of eyes to monitoring team.
/cc @openshift/openshift-team-monitoring

@openshift-ci openshift-ci Bot requested a review from a team May 18, 2021 06:21
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2021
@simonpasquier

Copy link
Copy Markdown
Contributor

/retitle Bug 1953798: Remove the upstream KubeAPIErrorBudgetBurn alerts

@openshift-ci openshift-ci Bot changed the title Remove the upstream KubeAPIErrorBudgetBurn alerts Bug 1953798: Remove the upstream KubeAPIErrorBudgetBurn alerts May 18, 2021
@simonpasquier

Copy link
Copy Markdown
Contributor

/lgtm
thanks!

@openshift-ci openshift-ci Bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 18, 2021
@openshift-ci

openshift-ci Bot commented May 18, 2021

Copy link
Copy Markdown
Contributor

@ihcsim: This pull request references Bugzilla bug 1953798, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

Details

In response to this:

Bug 1953798: Remove the upstream KubeAPIErrorBudgetBurn alerts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested a review from wangke19 May 18, 2021 07:04
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2021
@simonpasquier

Copy link
Copy Markdown
Contributor

/retest

Comment thread pkg/manifests/manifests.go Outdated
@dgrisonnet

Copy link
Copy Markdown
Member

/hold

@openshift-ci openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm Indicates that a PR is ready to be merged. labels May 18, 2021
Signed-off-by: Ivan Sim <isim@redhat.com>
@dgrisonnet

Copy link
Copy Markdown
Member

/lgtm
/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2021
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2021
@openshift-ci

openshift-ci Bot commented May 18, 2021

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, ihcsim, s-urbaniak, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dgrisonnet,s-urbaniak,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dgrisonnet

Copy link
Copy Markdown
Member

/retest

@dgrisonnet

Copy link
Copy Markdown
Member

/test e2e-agnostic

@dgrisonnet

Copy link
Copy Markdown
Member

/retest

1 similar comment
@ihcsim

ihcsim commented May 20, 2021

Copy link
Copy Markdown
Author

/retest

@wking

wking commented May 25, 2021

Copy link
Copy Markdown
Member

Tide seems to have gotten lost.

/retest

@simonpasquier

Copy link
Copy Markdown
Contributor

@ihcsim can you check with DPTP what happens with the tests? They seem to be stuck...

@droslean

Copy link
Copy Markdown
Member

/refresh

@droslean

Copy link
Copy Markdown
Member

/test all

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci

openshift-ci Bot commented May 25, 2021

Copy link
Copy Markdown
Contributor

@ihcsim: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-single-node ad7d615 link /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b728aa6 into openshift:master May 25, 2021
@openshift-ci

openshift-ci Bot commented May 25, 2021

Copy link
Copy Markdown
Contributor

@ihcsim: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1953798 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1953798: Remove the upstream KubeAPIErrorBudgetBurn alerts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants