WIP: remove API server SLO alerts and recording rules#1076
Conversation
Signed-off-by: paulfantom <pawel@krupa.net.pl>
Signed-off-by: paulfantom <pawel@krupa.net.pl>
Signed-off-by: paulfantom <pawel@krupa.net.pl>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@s-urbaniak should we also wait for #1073 which refactors the function to remove rules? |
|
@dgrisonnet yes, that sounds reasonable 👍 there is no need to hurry for this to merge. |
|
@s-urbaniak: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@s-urbaniak: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close superseded by #1164 |
|
@simonpasquier: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This removes API server SLO alerts and recording rules from the monitoring stack.
TBD: Another PR against cluster-kube-apiserver-operator will reintroduce them.
The net change will be none, hence no changelog is needed for now.
Note: This builds on top of #1044 which must land first.
/hold
/cc @openshift/openshift-team-monitoring
/cc @deads2k @sttts the net changes here are 362dc97 and 7dc9de5