Skip to content

WIP: remove API server SLO alerts and recording rules#1076

Closed
s-urbaniak wants to merge 12 commits into
openshift:masterfrom
s-urbaniak:apiserver-slos
Closed

WIP: remove API server SLO alerts and recording rules#1076
s-urbaniak wants to merge 12 commits into
openshift:masterfrom
s-urbaniak:apiserver-slos

Conversation

@s-urbaniak

Copy link
Copy Markdown
Contributor

This removes API server SLO alerts and recording rules from the monitoring stack.
TBD: Another PR against cluster-kube-apiserver-operator will reintroduce them.
The net change will be none, hence no changelog is needed for now.

Note: This builds on top of #1044 which must land first.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

/hold
/cc @openshift/openshift-team-monitoring
/cc @deads2k @sttts the net changes here are 362dc97 and 7dc9de5

@openshift-ci-robot openshift-ci-robot requested a review from a team March 10, 2021 14:00
@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 10, 2021
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2021
@dgrisonnet

Copy link
Copy Markdown
Member

@s-urbaniak should we also wait for #1073 which refactors the function to remove rules?

@s-urbaniak

Copy link
Copy Markdown
Contributor Author

@dgrisonnet yes, that sounds reasonable 👍 there is no need to hurry for this to merge.

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@s-urbaniak: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2021
@openshift-ci

openshift-ci Bot commented Apr 27, 2021

Copy link
Copy Markdown
Contributor

@s-urbaniak: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-agnostic-operator 7dc9de5 link /test e2e-agnostic-operator
ci/prow/e2e-agnostic 7dc9de5 link /test e2e-agnostic
ci/prow/e2e-aws-single-node 7dc9de5 link /test e2e-aws-single-node
ci/prow/jsonnet-fmt 7dc9de5 link /test jsonnet-fmt
ci/prow/rules 7dc9de5 link /test rules

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonpasquier

Copy link
Copy Markdown
Contributor

/close

superseded by #1164

@openshift-ci

openshift-ci Bot commented May 25, 2021

Copy link
Copy Markdown
Contributor

@simonpasquier: Closed this PR.

Details

In response to this:

/close

superseded by #1164

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot closed this May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants