Skip to content

Poll in bootstrap user e2e test #22070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 27, 2019
Merged

Poll in bootstrap user e2e test #22070

openshift-merge-robot merged 1 commit into from
Feb 27, 2019

Conversation

@enj
Copy link
Contributor

@enj enj commented Feb 18, 2019

The OAuth server may not be ready when this test runs. Thus we need to poll for a while to make sure any failures are not flakes.

Signed-off-by: Monis Khan [email protected]

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 18, 2019
@enj enj force-pushed the enj/t/poll_login_e2e branch from 5332dea to 65bddc3 Compare February 18, 2019 19:04
@enj enj changed the title Poll is bootstrap user e2e test Poll in bootstrap user e2e test Feb 18, 2019
mrogers950
mrogers950 approved these changes Feb 18, 2019
View reviewed changes
Copy link

@mrogers950 mrogers950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, mrogers950

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 18, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@enj
Copy link
Contributor Author

enj commented Feb 18, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 18, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 18, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton
Copy link
Contributor

smarterclayton commented Feb 19, 2019

/retest

1 similar comment
@smarterclayton
Copy link
Contributor

smarterclayton commented Feb 19, 2019

/retest

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Feb 19, 2019

Will this fix failures like https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/1266/pull-ci-openshift-installer-master-e2e-aws/3889#openshift-tests-the-bootstrap-user-should-successfully-login-with-password-decoded-from-kubeadmin-secret-suiteopenshiftconformanceparallel ?

@smarterclayton
Copy link
Contributor

smarterclayton commented Feb 19, 2019

/retest

1 similar comment
@stlaz
Copy link
Contributor

stlaz commented Feb 19, 2019

/retest

@stlaz
Copy link
Contributor

stlaz commented Feb 19, 2019

@abhinavdahiya yes

@stlaz
Copy link
Contributor

stlaz commented Feb 19, 2019

/retest

@wking
Copy link
Member

wking commented Feb 19, 2019

e2e-aws:

level=fatal msg="failed to initialize the cluster: Cluster operator network has not yet reported success"

/retest

@stlaz
Copy link
Contributor

stlaz commented Feb 19, 2019

/retest

1 similar comment
@enj
Copy link
Contributor Author

enj commented Feb 19, 2019

/retest

@runcom runcom mentioned this pull request Feb 19, 2019
Merged
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@enj
Copy link
Contributor Author

enj commented Feb 19, 2019

/retest

2 similar comments
@stlaz
Copy link
Contributor

stlaz commented Feb 19, 2019

/retest

@smarterclayton
Copy link
Contributor

smarterclayton commented Feb 19, 2019

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 21, 2019

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2019
@enj enj added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2019
@enj
Copy link
Contributor Author

enj commented Feb 21, 2019

/hold cancel

This should work as expected now.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@enj enj removed the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2019
@enj enj force-pushed the enj/t/poll_login_e2e branch from 45b2502 to 53124ec Compare February 22, 2019 02:53
@enj enj added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2019
@stlaz
Copy link
Contributor

stlaz commented Feb 22, 2019

/retest

1 similar comment
@enj
Copy link
Contributor Author

enj commented Feb 23, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@enj
Copy link
Contributor Author

enj commented Feb 25, 2019

/hold

Needs some work.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2019
@enj
Poll in bootstrap user e2e test
ae55354 
The OAuth server may not be ready when this test runs.  Thus we need
to poll for a while to make sure any failures are not flakes.

Signed-off-by: Monis Khan <[email protected]>
@enj enj removed the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2019
@enj enj force-pushed the enj/t/poll_login_e2e branch from 53124ec to ae55354 Compare February 26, 2019 19:54
@enj
Copy link
Contributor Author

enj commented Feb 26, 2019

/hold cancel

Got the ginko stuff sorted out.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2019
@enj enj added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 26, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 27, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@enj
Copy link
Contributor Author

enj commented Feb 27, 2019

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit 90ed23f into openshift:master Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

1 more reviewer

@mrogers950 mrogers950 mrogers950 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mrogers950 mrogers950

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.