POC of lib-go fix

[deads2k]

#1276 plus the nil check to handle the case where a lister gives you a nil answer to a GET.

/hold don't merge this

/assign @jerpeter1

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deads2k]

2021-12-20T14:55:54.191194130Z E1220 14:55:54.191152       1 runtime.go:78] Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)
2021-12-20T14:55:54.191194130Z goroutine 1636 [running]:
2021-12-20T14:55:54.191194130Z k8s.io/apimachinery/pkg/util/runtime.logPanic({0x2212340, 0x3e254c0})
2021-12-20T14:55:54.191194130Z 	k8s.io/apimachinery@v0.23.0/pkg/util/runtime/runtime.go:74 +0x7d
2021-12-20T14:55:54.191194130Z k8s.io/apimachinery/pkg/util/runtime.HandleCrash({0xc004464528, 0x1, 0x21151a0})
2021-12-20T14:55:54.191194130Z 	k8s.io/apimachinery@v0.23.0/pkg/util/runtime/runtime.go:48 +0x75
2021-12-20T14:55:54.191194130Z panic({0x2212340, 0x3e254c0})
2021-12-20T14:55:54.191194130Z 	runtime/panic.go:1038 +0x215
2021-12-20T14:55:54.191194130Z k8s.io/api/core/v1.(*Secret).GetResourceVersion(0x0)
2021-12-20T14:55:54.191194130Z 	<autogenerated>:1 +0x22
2021-12-20T14:55:54.191194130Z github.com/openshift/library-go/pkg/operator/resource/resourceapply.getResourceVersion({0x293f8e8, 0x0})
2021-12-20T14:55:54.191194130Z 	github.com/openshift/library-go@v0.0.0-20211217155025-d48a1fb9b7c2/pkg/operator/resource/resourceapply/resource_cache.go:76 +0x43
2021-12-20T14:55:54.191194130Z github.com/openshift/library-go/pkg/operator/resource/resourceapply.(*resourceCache).SafeToSkipApply(0xc00049a070, {0x293f8e8, 0xc00305c140}, {0x293f8e8, 0x0})
2021-12-20T14:55:54.191194130Z 	github.com/openshift/library-go@v0.0.0-20211217155025-d48a1fb9b7c2/pkg/operator/resource/resourceapply/resource_cache.go:132 +0x139
2021-12-20T14:55:54.191194130Z github.com/openshift/library-go/pkg/operator/resource/resourceapply.ApplySecretImproved({0x2969b30, 0xc0033a9ec0}, {0x2919cc0, 0xc003c14f00}, {0x29a74e0, 0xc001596000}, 0xc00305c140, {0x293d818, 0xc00049a070})
2021-12-20T14:55:54.191194130Z 	github.com/openshift/library-go@v0.0.0-20211217155025-d48a1fb9b7c2/pkg/operator/resource/resourceapply/core.go:347 +0x12f

could add the check in the applysecret itself, but that seems less desireable.

[openshift-ci]

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-operator-single-node	4446352	link	false	/test e2e-gcp-operator-single-node
ci/prow/k8s-e2e-gcp	4446352	link	true	/test k8s-e2e-gcp
ci/prow/unit	4446352	link	true	/test unit
ci/prow/e2e-aws	4446352	link	true	/test e2e-aws
ci/prow/verify-deps	4446352	link	true	/test verify-deps
ci/prow/e2e-gcp-operator	4446352	link	true	/test e2e-gcp-operator
ci/prow/e2e-aws-operator-disruptive-single-node	4446352	link	false	/test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-aws-serial	4446352	link	true	/test e2e-aws-serial
ci/prow/e2e-upgrade	4446352	link	true	/test e2e-upgrade
ci/prow/e2e-aws-single-node	4446352	link	false	/test e2e-aws-single-node
ci/prow/k8s-e2e-gcp-serial	4446352	link	false	/test k8s-e2e-gcp-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.