Skip to content

Bug 1948431: Bump openshift/api to get the necessary CSIMigration feature gates#344

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
huffmanca:bump-api
Apr 13, 2021
Merged

Bug 1948431: Bump openshift/api to get the necessary CSIMigration feature gates#344
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
huffmanca:bump-api

Conversation

@huffmanca
Copy link
Copy Markdown
Contributor

@huffmanca huffmanca commented Apr 9, 2021 •
edited
Loading

The CSI Migration tech preview feature is included in openshift/api, and I'm bumping the version here so that the FeatureGate can be propagated correctly.

Goal of this PR is to apply --feature-gate=CSIMigrationAWS=true,CSIMigrationOpenStack=true to kube-scheduler when TechPreviewNoUpgrade featureSet is enabled, which was introduced in openshift/api#880 .

@huffmanca huffmanca changed the title Update openshift/api Bump openshift/api to get the necessary CSIMigration feature gates. Apr 9, 2021
@jsafrane
Copy link
Copy Markdown

jsafrane commented Apr 12, 2021

/retest

@jsafrane
Copy link
Copy Markdown

jsafrane commented Apr 12, 2021

/retitle Bug 1948431: Bump openshift/api to get the necessary CSIMigration feature gates

@openshift-ci-robot openshift-ci-robot changed the title Bump openshift/api to get the necessary CSIMigration feature gates. Bug 1948431: Bump openshift/api to get the necessary CSIMigration feature gates Apr 12, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 12, 2021
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 12, 2021

@huffmanca: This pull request references Bugzilla bug 1948431, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1948431: Bump openshift/api to get the necessary CSIMigration feature gates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Copy Markdown

jsafrane commented Apr 12, 2021

/bugzilla refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 12, 2021

@jsafrane: This pull request references Bugzilla bug 1948431, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (piqin@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 12, 2021
soltysh
soltysh approved these changes Apr 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2021
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huffmanca, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2021
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e57fa88 into openshift:master Apr 13, 2021
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 13, 2021

@huffmanca: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1948431 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1948431: Bump openshift/api to get the necessary CSIMigration feature gates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damemi damemi Awaiting requested review from damemi

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@huffmanca @jsafrane @openshift-ci-robot @openshift-bot @soltysh @openshift-merge-robot