Use cluster config for DNS management setup #91
Conversation
Use the cluster config API where possible for DNS management setup. * Get the base domain from the cluster config * Discover the AWS region from environment or EC2 metadata
openshift-ci-robot
added
the
size/XXL
openshift-ci-robot
added
the
approved
|
DNS tested manually. Once openshift/api#145 lands and the installer is updated to use it, we can finally do some e2e tests for this in origin. |
|
Or I could introduce something in the operator e2e tests and migrate to origin ASAP? |
|
I take it back, adding the test to operator would require adding a bunch of test scaffolding from origin to do things like execute commands from a pods. Not sure if we want to deal with that now when we're so close to being able to write the tests in origin. Anyway, I tested this one myself. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
Whoops, I nearly forgot to block on openshift/installer#934 (I was testing against a patched installer!) |
|
/retest |
1 similar comment
|
/retest |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
Hello? Bots? /retest |
|
/refresh |
5 participants
Use the cluster config API where possible for DNS management setup.